Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements #1228

Merged
merged 4 commits into from
May 2, 2023
Merged

Logging improvements #1228

merged 4 commits into from
May 2, 2023

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented May 2, 2023

Description

Added a few logging improvements which should improve cold starts.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1228 (be9caae) into dev (4a9a38e) will decrease coverage by 51.99%.
The diff coverage is 0.00%.

❗ Current head be9caae differs from pull request most recent head 78dc021. Consider uploading reports for the commit 78dc021 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1228       +/-   ##
===========================================
- Coverage   83.97%   31.98%   -51.99%     
===========================================
  Files          34       34               
  Lines        1903     1904        +1     
  Branches      366      365        -1     
===========================================
- Hits         1598      609      -989     
- Misses        234     1294     +1060     
+ Partials       71        1       -70     
Flag Coverage Δ
unittests 31.98% <0.00%> (-51.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 19.39% <0.00%> (-69.75%) ⬇️
azure_functions_worker/utils/dependency.py 33.08% <0.00%> (-53.39%) ⬇️

... and 22 files with indirect coverage changes

@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/add_logging branch from 005b2fc to 1d8b557 Compare May 2, 2023 02:09
@gavin-aguiar gavin-aguiar merged commit 1eebabc into dev May 2, 2023
@gavin-aguiar gavin-aguiar deleted the gaaguiar/add_logging branch May 2, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants