Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warmup trigger e2e tests #1295

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Add warmup trigger e2e tests #1295

merged 3 commits into from
Aug 2, 2023

Conversation

pdthummar
Copy link
Contributor

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1295 (ac3d31f) into dev (222883c) will decrease coverage by 52.51%.
The diff coverage is n/a.

❗ Current head ac3d31f differs from pull request most recent head e6545b8. Consider uploading reports for the commit e6545b8 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1295       +/-   ##
===========================================
- Coverage   84.79%   32.28%   -52.51%     
===========================================
  Files          34       34               
  Lines        1914     1914               
  Branches      363      363               
===========================================
- Hits         1623      618     -1005     
- Misses        222     1295     +1073     
+ Partials       69        1       -68     
Flag Coverage Δ
unittests 32.28% <ø> (-52.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

@pdthummar pdthummar merged commit f73300b into dev Aug 2, 2023
@pdthummar pdthummar deleted the pthummar/add_warmup_e2e_tests branch August 2, 2023 15:44
@gavin-aguiar gavin-aguiar linked an issue Aug 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warmup trigger e2e tests
2 participants