Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove masking E2E test failures #1483

Merged
merged 32 commits into from
May 15, 2024
Merged

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Apr 18, 2024

Description

Separates the E2E test script into 3 different scripts: functions worker process count & threadpool thread count tests, E2E tests, and deferred bindings tests. All the tests will run but if any test in these 3 workflows fails, the pipeline will fail.

Changed issue and feature request templates to be more usable.

Added extra tests

  • Generic binding implicit output with a None return value and no type hint
  • Blueprints with blueprint.py in a separate folder
  • FWPC and blueprints in a separate folder
  • newrelic and PIWD

Popped env variables in tearDown() for fwpc and tptc tests.

Future changes:

  • checking in permissions as part of source control
  • configuring matrix / environment to shorten script

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.11%. Comparing base (330783f) to head (206b28e).
Report is 10 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1483       +/-   ##
===========================================
- Coverage   84.64%   32.11%   -52.54%     
===========================================
  Files          35       36        +1     
  Lines        2052     2317      +265     
  Branches      387      439       +52     
===========================================
- Hits         1737      744      -993     
- Misses        232     1571     +1339     
+ Partials       83        2       -81     
Flag Coverage Δ
unittests 32.11% <ø> (-52.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria marked this pull request as ready for review April 23, 2024 16:33
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/workflows/ci_e2e_workflow.yml Outdated Show resolved Hide resolved
.github/workflows/ci_e2e_workflow.yml Outdated Show resolved Hide resolved
.github/workflows/ci_e2e_workflow.yml Outdated Show resolved Hide resolved
@YunchuWang YunchuWang self-requested a review May 15, 2024 21:39
@hallvictoria hallvictoria merged commit cd13c6a into dev May 15, 2024
59 of 62 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/e2e-test-fix branch May 15, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants