-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove masking E2E test failures #1483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1483 +/- ##
===========================================
- Coverage 84.64% 32.11% -52.54%
===========================================
Files 35 36 +1
Lines 2052 2317 +265
Branches 387 439 +52
===========================================
- Hits 1737 744 -993
- Misses 232 1571 +1339
+ Partials 83 2 -81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hallvictoria
requested review from
vrdmr,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
April 23, 2024 16:33
YunchuWang
reviewed
May 7, 2024
vrdmr
reviewed
May 9, 2024
YunchuWang
approved these changes
May 15, 2024
vrdmr
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separates the E2E test script into 3 different scripts: functions worker process count & threadpool thread count tests, E2E tests, and deferred bindings tests. All the tests will run but if any test in these 3 workflows fails, the pipeline will fail.
Changed issue and feature request templates to be more usable.
Added extra tests
Popped env variables in tearDown() for fwpc and tptc tests.
Future changes:
Fixes #
PR information
Quality of Code and Contribution Guidelines