Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed default threadpool count for pyver> 3.9 #1575

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Sep 11, 2024

Description

From python 3.9 onwards, the threadpool count is not set, worker won't be putting a limit on the max_workers count in the created threadpool.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@gavin-aguiar gavin-aguiar changed the title Fixed default threadpool count for pyver> 3.9 fix: Fixed default threadpool count for pyver> 3.9 Sep 11, 2024
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. qq - why wasn't it caught before in the tests - where the expectation is that the number of threads default should not have been 1 in the first place

@hallvictoria hallvictoria merged commit 67bb824 into dev Sep 18, 2024
27 checks passed
@hallvictoria hallvictoria deleted the gaaguiar/tpc_fix branch September 18, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants