Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the Perf Testing workflow #994

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Apr 1, 2022

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr marked this pull request as draft April 1, 2022 00:26
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #994 (5730a00) into dev (f4d51bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #994   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files          33       33           
  Lines        1677     1677           
  Branches      267      267           
=======================================
  Hits         1388     1388           
  Misses        226      226           
  Partials       63       63           
Flag Coverage Δ
unittests 82.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d51bd...5730a00. Read the comment docs.

@YunchuWang YunchuWang force-pushed the vameru/correcting_perf_workflow branch from 6836a83 to 5730a00 Compare April 8, 2022 16:01
@YunchuWang YunchuWang marked this pull request as ready for review April 8, 2022 17:34
@YunchuWang YunchuWang requested a review from pdthummar as a code owner April 8, 2022 17:34
@vrdmr vrdmr merged commit 8800edd into dev Apr 8, 2022
@vrdmr vrdmr deleted the vameru/correcting_perf_workflow branch April 8, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants