Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update namespaces and assembly names #185

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

JatinSanghvi
Copy link
Contributor

@JatinSanghvi JatinSanghvi commented Feb 21, 2022

  • Updated namespaces and assembly names to be consistent and to align with other WebJobs extensions. Other extensions have namespaces and assembly names starting with Microsoft (the company name is required). I don't expect this to impact client applications as those application project files reference packages instead of assemblies, and the package name is not changed. Also, they will receive the update only on opting to update to next version of the extension package.

  • Deleted two files not in use.

  • Add VS Code file information in .gitignore.

WebJobs SDK code for reference: 1, 2.

@JatinSanghvi JatinSanghvi changed the title Update namespace and assembly names Update namespaces and assembly names Feb 21, 2022
Copy link
Member

@v-shenoy v-shenoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filenames starting with Webjobs.Extensions.RabbitMQ should also be changed to include Microsoft.Azure.

@JatinSanghvi
Copy link
Contributor Author

JatinSanghvi commented Feb 21, 2022

I think the filenames starting with Webjobs.Extensions.RabbitMQ should also be changed to include Microsoft.Azure.

This is to keep the project file names smaller as we have in https://cs.github.com/Azure/azure-webjobs-sdk?q=path%3AWebjobs*csproj or in this repository. The root-namespace and assembly names are selected same to be project file names by default, but since both differ, we are adding RootNamespace and AssemblyName XML elements to the CSPROJ files. The projects in WebJobs SDK repo also does the same. I think that RabbitMQ extension followed the same convention as in WebJobs SDK repo but did not add the two XML elements as the original repo did.

@ghost ghost removed the Needs: Author Feedback label Feb 21, 2022
@JatinSanghvi JatinSanghvi merged commit 232c45d into Azure:dev Feb 21, 2022
@JatinSanghvi JatinSanghvi deleted the update-namespaces branch February 21, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants