Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in uamqp import logic #157

Merged
merged 2 commits into from Apr 10, 2020
Merged

Fixed bug in uamqp import logic #157

merged 2 commits into from Apr 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2020


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest -s <project root>/azext_iot/tests
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.

@ghost ghost requested a review from digimaun as a code owner April 10, 2020 22:28
@ghost
Copy link
Author

ghost commented Apr 10, 2020

Help is now working

image

Test passing (no need for uamqp):

image

Must install uamqp for these tests:

  1. [Passing] test_iot_messaging_int.py

image

  1. [Passing] test_iot_central_int.py
    image

  2. [Passing] test_iot_utility_unit.py
    image

@digimaun digimaun merged commit 79fe125 into Azure:dev Apr 10, 2020
@ghost ghost deleted the prbans/fix-uamqp-import branch May 4, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant