Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate messages now performs primitive type matching #169

Merged
merged 15 commits into from Apr 29, 2020
Merged

Validate messages now performs primitive type matching #169

merged 15 commits into from Apr 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 23, 2020


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.

@ghost ghost requested a review from digimaun as a code owner April 23, 2020 01:46
@ghost ghost marked this pull request as draft April 23, 2020 01:46
@ghost
Copy link
Author

ghost commented Apr 23, 2020

image

@ghost ghost marked this pull request as ready for review April 23, 2020 02:14
@ghost ghost marked this pull request as draft April 23, 2020 03:32
@ghost ghost marked this pull request as ready for review April 23, 2020 03:36
@ghost
Copy link
Author

ghost commented Apr 23, 2020

image

@ghost
Copy link
Author

ghost commented Apr 29, 2020

image

@@ -412,3 +436,29 @@ def ensure_pkg_resources_entries():
pkg_resources.working_set.add_entry(extension_path)

return


class ISO8601Validator:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only change to this file

@digimaun digimaun merged commit acff680 into Azure:dev Apr 29, 2020
@ghost ghost deleted the prbans/validate-field-names branch May 4, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant