Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign MSI principal IT #308

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Assign MSI principal IT #308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
508c986
Assign MSI principal test.
digimaun Jan 30, 2021
6e392d5
add skip test decorator
digimaun Jan 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 65 additions & 16 deletions azext_iot/tests/digitaltwins/test_dt_resource_lifecycle_int.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,36 @@ class TestDTResourceLifecycle(DTLiveScenarioTest):
def __init__(self, test_case):
super(TestDTResourceLifecycle, self).__init__(test_case)

@pytest.mark.skipif(
not all(
[
settings.env.azext_dt_ep_rg,
settings.env.azext_dt_ep_eventgrid_topic,
settings.env.azext_dt_ep_servicebus_topic,
settings.env.azext_dt_ep_servicebus_namespace,
]
),
reason="Required env vars missing.",
)
def test_dt_resource(self):
self.wait_for_capacity(capacity=3)

eventgrid_topic_id = self.cmd(
"eventgrid topic show -g {} -n {}".format(
settings.env.azext_dt_ep_rg, settings.env.azext_dt_ep_eventgrid_topic
)
).get_output_in_json()["id"]

servicebus_topic_id = self.cmd(
"servicebus topic show -g {} -n {} --namespace-name {}".format(
settings.env.azext_dt_ep_rg,
settings.env.azext_dt_ep_servicebus_topic,
settings.env.azext_dt_ep_servicebus_namespace,
)
).get_output_in_json()["id"]

scope_ids = [eventgrid_topic_id, servicebus_topic_id]

instance_names = [generate_resource_id(), generate_resource_id()]
create_output = self.cmd(
"dt create -n {} -g {} -l {} --tags {}".format(
Expand All @@ -79,6 +106,18 @@ def test_dt_resource(self):
MOCK_RESOURCE_TAGS_DICT,
)

show_output = self.cmd(
"dt show -n {}".format(instance_names[0])
).get_output_in_json()

assert_common_resource_attributes(
show_output,
instance_names[0],
self.rg,
self.region,
MOCK_RESOURCE_TAGS_DICT,
)

# Explictly assert create prevents provisioning on a name conflict (across regions)
self.cmd(
"dt create -n {} -g {} -l {} --tags {}".format(
Expand All @@ -92,7 +131,9 @@ def test_dt_resource(self):

# No location specified. Use the resource group location.
create_msi_output = self.cmd(
"dt create -n {} -g {} --assign-identity".format(instance_names[1], self.rg)
"dt create -n {} -g {} --assign-identity --scopes {}".format(
instance_names[1], self.rg, " ".join(scope_ids)
)
).get_output_in_json()
self.track_instance(create_msi_output)

Expand All @@ -105,18 +146,6 @@ def test_dt_resource(self):
assign_identity=True,
)

show_output = self.cmd(
"dt show -n {}".format(instance_names[0])
).get_output_in_json()

assert_common_resource_attributes(
show_output,
instance_names[0],
self.rg,
self.region,
MOCK_RESOURCE_TAGS_DICT,
)

show_msi_output = self.cmd(
"dt show -n {} -g {}".format(instance_names[1], self.rg)
).get_output_in_json()
Expand All @@ -130,11 +159,27 @@ def test_dt_resource(self):
assign_identity=True,
)

role_assignment_egt_list = self.cmd(
"role assignment list --scope {} --assignee {}".format(
eventgrid_topic_id, show_msi_output["identity"]["principalId"]
)
).get_output_in_json()
assert len(role_assignment_egt_list) == 1

role_assignment_sbt_list = self.cmd(
"role assignment list --scope {} --assignee {}".format(
servicebus_topic_id, show_msi_output["identity"]["principalId"]
)
).get_output_in_json()
assert len(role_assignment_sbt_list) == 1

# Update tags and disable MSI
updated_tags = "env=test tier=premium"
updated_tags_dict = {"env": "test", "tier": "premium"}
remove_msi_output = self.cmd(
"dt create -n {} -g {} --assign-identity false --tags {}".format(instance_names[1], self.rg, updated_tags)
"dt create -n {} -g {} --assign-identity false --tags {}".format(
instance_names[1], self.rg, updated_tags
)
).get_output_in_json()

assert_common_resource_attributes(
Expand Down Expand Up @@ -633,10 +678,14 @@ def assert_common_endpoint_attributes(
assert endpoint_output["properties"]["createdTime"]

if dead_letter_secret:
assert endpoint_output["properties"]["deadLetterSecret"]
assert endpoint_output["properties"][
"deadLetterSecret"
], "Expected deadletter secret."

if dead_letter_endpoint:
assert endpoint_output["properties"]["deadLetterUri"]
assert endpoint_output["properties"][
"deadLetterUri"
], "Expected deadletter Uri."

# Currently DT -> EventGrid is only key based.
if endpoint_type == ADTEndpointType.eventgridtopic:
Expand Down