Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoT Hub Cosmos DB endpoint GA #674

Merged
merged 9 commits into from
Aug 23, 2023
Merged

IoT Hub Cosmos DB endpoint GA #674

merged 9 commits into from
Aug 23, 2023

Conversation

vilit1
Copy link
Contributor

@vilit1 vilit1 commented Jun 30, 2023

Cosmos db endpoints are going GA. Properties changed but nothing else should change.

The changes in this pr should not be affected by sdk version (between preview and GA) since they check iot hub properties.

Will update for review when the swagger is finalized.

Will mark as ready once service is out.

Azure/azure-rest-api-specs#23791

still waiting on sdk


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@vilit1 vilit1 marked this pull request as ready for review August 15, 2023 23:52
@vilit1 vilit1 requested a review from digimaun as a code owner August 15, 2023 23:52
@vilit1
Copy link
Contributor Author

vilit1 commented Aug 23, 2023

Proof of concept for (preview version of) new sdk working locally:

image
image

older sdk still passing tests:
https://dev.azure.com/azureiotdevxp/aziotcli/_build/results?buildId=9306&view=results

@vilit1 vilit1 merged commit 082d2bd into Azure:dev Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants