Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages for iot explorer #583

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

Elsie4ever
Copy link
Collaborator


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the Azure IoT Explorer!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit tests?
  • Have all unit tests passed locally? (by running npm run test command)
  • Have you updated the README.md with new screenshots if significant changes have been made?
  • Have you update the package version if the current version in package.json is not higher than the version released?

@Elsie4ever Elsie4ever requested a review from YingXue November 17, 2022 00:25
"electron": "18.0.0",
"electron-builder": "23.3.3",
"electron": "18.3.15",
"electron-builder": "22.10.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just want to double check that this version downgrade is intentional.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is intentional🥲 npm audit recommended the fix and that did fix 6 high vulnerabilities. Would you suggest to revert the downgrade?

Copy link
Member

@YingXue YingXue Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it is intentional, let's keep the change. Security is always a priority.

@YingXue YingXue merged commit 7df93fd into Azure:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants