Address comments

Azure · Jan 3, 2023 · ee9a740 · ee9a740
1 parent 97a068f
commit ee9a740
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/iothub/service/tests/QueryTests.cs b/iothub/service/tests/QueryTests.cs
@@ -298,12 +298,12 @@ public void QueryResultUserSuppliedContinuationTest()
         public void QueryResult_OverrideDefaultJsonSerializer_Ok()
         {
             // simulate json serialize/deserialize
-            var serverQueryResult = new QueryResult()
+            var serverQueryResult = new QueryResult
             {
                 Type = QueryResultType.Twin,
-                Items = new List<Twin>()
+                Items = new List<Twin>
                 {
-                    new Twin()
+                    new Twin
                     {
                         DeviceId = "test",
                     }
@@ -314,7 +314,7 @@ public void QueryResult_OverrideDefaultJsonSerializer_Ok()
             var settings = new JsonSerializerSettings { MaxDepth = 3 };
             // serialize
             var jsonQueryResult = JsonConvert.SerializeObject(serverQueryResult, settings);
-            Assert.AreEqual("{\"type\":\"twin\",\"items\":[{\"deviceId\":\"test\",\"etag\":null,\"version\":null,\"properties\":{\"desired\":{},\"reported\":{}}}],\"continuationToken\":\"GYUVJDBJFKJ\"}", jsonQueryResult);
+            jsonQueryResult.Should().Be("{\"type\":\"twin\",\"items\":[{\"deviceId\":\"test\",\"etag\":null,\"version\":null,\"properties\":{\"desired\":{},\"reported\":{}}}],\"continuationToken\":\"GYUVJDBJFKJ\"}");
             // deserialize
             var clientQueryResult = JsonConvert.DeserializeObject<QueryResult>(jsonQueryResult, settings);
         }
@@ -323,12 +323,12 @@ public void QueryResult_OverrideDefaultJsonSerializer_Ok()
         public void QueryResult_OverrideDefaultJsonSerializer_ExceedMaxDepthThrows()
         {
             // simulate json serialize/deserialize
-            var serverQueryResult = new QueryResult()
+            var serverQueryResult = new QueryResult
             {
                 Type = QueryResultType.Twin,
-                Items = new List<Twin>()
+                Items = new List<Twin>
                 {
-                    new Twin()
+                    new Twin
                     {
                         DeviceId = "test",
                     }
@@ -339,8 +339,7 @@ public void QueryResult_OverrideDefaultJsonSerializer_ExceedMaxDepthThrows()
             var settings = new JsonSerializerSettings { MaxDepth = 2 };
             // serialize
             var jsonQueryResult = JsonConvert.SerializeObject(serverQueryResult, settings);
-            Assert.AreEqual("{\"type\":\"twin\",\"items\":[{\"deviceId\":\"test\",\"etag\":null,\"version\":null,\"properties\":{\"desired\":{},\"reported\":{}}}],\"continuationToken\":\"GYUVJDBJFKJ\"}", jsonQueryResult);
-            // deserialize
+            jsonQueryResult.Should().Be("{\"type\":\"twin\",\"items\":[{\"deviceId\":\"test\",\"etag\":null,\"version\":null,\"properties\":{\"desired\":{},\"reported\":{}}}],\"continuationToken\":\"GYUVJDBJFKJ\"}");            // deserialize
             // act
             Func<QueryResult> act = () => JsonConvert.DeserializeObject<QueryResult>(jsonQueryResult, settings);
 

diff --git a/iothub/service/tests/SerializationTests.cs b/iothub/service/tests/SerializationTests.cs
@@ -87,9 +87,9 @@ public void Twin_Json_OverrideDefaultJsonSerializer_Ok()
             var settings = new JsonSerializerSettings { MaxDepth = 2 };
             var twin = JsonConvert.DeserializeObject<Twin>(jsonString, settings);
 
-            Assert.IsNotNull(twin);
-            Assert.AreEqual(twin.DeviceId, "test");
-            Assert.AreEqual(twin.ETag, "AAAAAAAAAAM=");
+            twin.Should().NotBeNull();
+            twin.DeviceId.Should().Be("test");
+            twin.ETag.Should().Be("AAAAAAAAAAM=");
         }
 
         [TestMethod]