Fixing CA2000 #1699
Fixing CA2000 #1699
Conversation
azabbasi
requested review from
abhipsaMisra,
barustum,
bikamani,
drwill-ms,
jamdavi,
timtay-microsoft and
vinagesh
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| #else | ||
| using var store = new X509Store(StoreName.Root, StoreLocation.CurrentUser); | ||
| #endif | ||
| foreach (X509Certificate2 cert in _certs) |
There was a problem hiding this comment.
What do you think we intend to do here? The store looks to be a local X509Store variable, that we don't reference anywhere. Do we simply want to validate that the certificates can be added to any store? Do we think it's relevant if we add them to a new store or to the same store?
There was a problem hiding this comment.
I think this just installs certificates in the cert store , it's the current user's root store btw
https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509store?view=netframework-4.7.2
| // ProvisioningDeviceClient_ValidRegistrationId_AmqpWithProxy_SymmetricKey_RegisterOk_GroupEnrollment failing for me with System.PlatformNotSupportedException: Operation is not supported on this platform. | ||
| // When revisiting TLS12 work for DPS, we should figure out why. Perhaps the service needs to support it. | ||
| // ProvisioningDeviceClient_ValidRegistrationId_AmqpWithProxy_SymmetricKey_RegisterOk_GroupEnrollment failing for me with System.PlatformNotSupportedException: Operation is not supported on this platform. | ||
| // When revisiting TLS12 work for DPS, we should figure out why. Perhaps the service needs to support it. |
There was a problem hiding this comment.
RE on this: https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.sslprotocols?view=net-5.0
Short answer is it's only supported on >= .NET4.7.1
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
No description provided.