Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK Versions for release 2020-02-08 #1773

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

jamdavi
Copy link
Member

@jamdavi jamdavi commented Feb 5, 2021

Microsoft.Azure.Devices.Client 1.35.0

Bug fixes

Microsoft.Azure.Devices 1.30.0

  • Unused member removal
    • DeliveryFailureReason enum
    • EventHubPartitionKeyResolver class
    • SharedAccessSignatureAuthorizationRule class
    • SharedAccessSignature class
    • ISharedAccessSignatureCredential interface

@azabbasi
Copy link
Contributor

azabbasi commented Feb 5, 2021

Unused memeber removal can be another bullet point and the rest can be nested.

@azabbasi
Copy link
Contributor

azabbasi commented Feb 5, 2021

Unused memeber removal can be another bullet point and the rest can be nested.

or with smaller header size.

@azabbasi
Copy link
Contributor

azabbasi commented Feb 5, 2021

Include PR # for Add a log statement indicating a no-retry retry policy has been enabled

Copy link
Contributor

@azabbasi azabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, recommended some stuff for the release notes.

@abhipsaMisra
Copy link
Member

The retry policy related comment should be only under the device client nuget, I think you've mistakenly copied it over to the service nuget as well (our service clients currently do not have any kind of retry mechanism baked in).

@jamdavi
Copy link
Member Author

jamdavi commented Feb 5, 2021

The retry policy related comment should be only under the device client nuget, I think you've mistakenly copied it over to the service nuget as well (our service clients currently do not have any kind of retry mechanism baked in).

Correct. Good catch

@jamdavi jamdavi merged commit 3cab90e into master Feb 5, 2021
@jamdavi jamdavi deleted the release_02-05-2021 branch February 5, 2021 19:22
@jamdavi jamdavi changed the title Bump API Version for release 2020-02-05 Bump SDK Versions for release 2020-02-05 Feb 5, 2021
@jamdavi jamdavi changed the title Bump SDK Versions for release 2020-02-05 Bump SDK Versions for release 2020-02-08 Feb 8, 2021
timstewartm pushed a commit to timstewartm/azure-iot-sdk-csharp that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants