Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to configure websocket keep-alive #2352

Merged
merged 5 commits into from
Apr 26, 2022
Merged

Allow users to configure websocket keep-alive #2352

merged 5 commits into from
Apr 26, 2022

Conversation

drwill-ms
Copy link
Contributor

No description provided.

abhipsaMisra
abhipsaMisra reviewed Apr 19, 2022
View reviewed changes
iothub/device/src/ClientOptions.cs Outdated Show resolved Hide resolved
iothub/device/src/Transport/Amqp/AmqpConnectionHolder.cs Outdated Show resolved Hide resolved
iothub/device/src/Transport/AmqpIot/AmqpIotTransport.cs Outdated Show resolved Hide resolved
iothub/device/src/ClientOptions.cs Outdated Show resolved Hide resolved
iothub/device/src/Transport/Mqtt/MqttTransportSettings.cs Show resolved Hide resolved
abhipsaMisra
abhipsaMisra reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

iothub/device/src/Transport/AmqpIot/AmqpIotTransport.cs Show resolved Hide resolved
iothub/device/src/AmqpTransportSettings.cs Outdated Show resolved Hide resolved
@drwill-ms drwill-ms force-pushed the drwill/websocket-keepalive branch from 79b86f6 to ad57b19 Compare April 26, 2022 21:21
@drwill-ms drwill-ms force-pushed the drwill/websocket-keepalive branch from ad57b19 to 2bb786b Compare April 26, 2022 21:25
@drwill-ms drwill-ms marked this pull request as ready for review April 26, 2022 21:26
@drwill-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drwill-ms drwill-ms merged commit 82e8df7 into main Apr 26, 2022
@drwill-ms drwill-ms deleted the drwill/websocket-keepalive branch April 26, 2022 22:07
@brycewang-microsoft brycewang-microsoft mentioned this pull request May 9, 2022
Merged
timstewartm pushed a commit to timstewartm/azure-iot-sdk-csharp that referenced this pull request May 30, 2024
Allow users to configure websocket keep-alive (Azure#2352)
e98b4db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycewang-microsoft brycewang-microsoft brycewang-microsoft approved these changes

@jamdavi jamdavi jamdavi approved these changes

@timtay-microsoft timtay-microsoft timtay-microsoft approved these changes

@abhipsaMisra abhipsaMisra abhipsaMisra approved these changes

@azabbasi azabbasi Awaiting requested review from azabbasi

@andyk-ms andyk-ms Awaiting requested review from andyk-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drwill-ms @abhipsaMisra @timtay-microsoft @jamdavi @brycewang-microsoft