Consolidate ProductInfo helper methods into the ProductInfo class #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These helper methods were not used by any other class, so they should live within ProductInfo
timtay-microsoft
requested review from
drwill-ms,
abhipsaMisra,
azabbasi,
andyk-ms,
brycewang-microsoft and
tmahmood-microsoft
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
brycewang-microsoft
approved these changes
May 20, 2022
abhipsaMisra
approved these changes
May 20, 2022
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
…ure#2402) These helper methods were not used by any other class, so they should live within ProductInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helper methods were not used by any other class, so they should live within ProductInfo. All the moved methods were not accessible to users, so it is not a breaking change