Update api diff script #2869
Update api diff script #2869
Conversation
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
drwill-ms
force-pushed
the
drwill/api-diff
branch
from
25263e6 to
b3b5051
Compare
drwill-ms
force-pushed
the
drwill/api-diff
branch
from
b3b5051 to
0748633
Compare
drwill-ms
force-pushed
the
drwill/api-diff
branch
from
0748633 to
cbe1e5a
Compare
| { | ||
| $internalRootPath = Join-Path -Path $baseRootPath -Child "\iot-sdks-internals" | ||
| } | ||
|
|
||
| Write-Verbose "Using $internalRootPath for the internals sdk repository base directory." | ||
|
|
||
| # If we specify to use the preview directory on the command line we will set it as such | ||
| $compareDirectory = Join-Path -Path $internalRootPath -Child "\sdk_design_docs\CSharp\main" | ||
| if ($IsPreview) | ||
| $compareDirectory = Join-Path -Path $internalRootPath -Child "\sdk_design_docs\CSharp\previews-v2" |
There was a problem hiding this comment.
shouldn't this be main and the one in L143 be previews-v2?
There was a problem hiding this comment.
This will become main. It isn't a preview of our GA SDK v1.
I think we'll need to rename the current main directory to v1, and main will become v2.
Or something like that.
Thoughts?
There was a problem hiding this comment.
I see, that makes sense. We should probably also cut another preview at some point soon, else this previews/v2 -> preview diff will end up showing us a lot of outdated diffs (the preview branch hasn't been updated in a long long time). The only features in "preview" are dps client certificates and device streaming, both of which have their individual preview feature branches.
There was a problem hiding this comment.
We have nothing to preview besides v2, right?
There was a problem hiding this comment.
Nothing else right now, no.
No description provided.