-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate exceptions thrown out by different clients #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycewang-microsoft
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
October 17, 2022 22:11
We still have the following exceptions thrown or referred by different clients:
|
drwill-ms
reviewed
Oct 17, 2022
iothub/device/src/Authentication/AuthenticationWithTokenRefresh.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Oct 17, 2022
drwill-ms
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with all the changes except removing ArgumentOutOfRangeException, but I wouldn't die on that hill.
tmahmood-microsoft
approved these changes
Oct 18, 2022
drwill-ms
approved these changes
Oct 24, 2022
…bServiceException
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
Nov 9, 2022
iothub/device/src/Authentication/HsmAuthentication/Transport/HttpRequestResponseSerializer.cs
Show resolved
Hide resolved
drwill-ms
reviewed
Nov 9, 2022
drwill-ms
approved these changes
Nov 9, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate the following types of exception thrown out by different clients, and update doc comments for public APIs and relevant tests.
IOException
SocketException
WebSocketException
UnauthorizedAccessException
SwaggerException
HttpRequestException
IndexOutOfRangeException
CryptographicException