Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate exceptions thrown out by different clients #2887

Merged
merged 18 commits into from
Nov 10, 2022

Conversation

brycewang-microsoft
Copy link
Contributor

@brycewang-microsoft brycewang-microsoft commented Oct 17, 2022

Consolidate the following types of exception thrown out by different clients, and update doc comments for public APIs and relevant tests.

  • IOException
  • SocketException
  • WebSocketException
  • UnauthorizedAccessException
  • SwaggerException
  • HttpRequestException
  • IndexOutOfRangeException
  • CryptographicException

@brycewang-microsoft
Copy link
Contributor Author

brycewang-microsoft commented Oct 17, 2022

We still have the following exceptions thrown or referred by different clients:

  • SwaggerException
  • HttpRequestException
  • IndexOutOfRangeException
  • CryptographicException

Copy link
Contributor

@drwill-ms drwill-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all the changes except removing ArgumentOutOfRangeException, but I wouldn't die on that hill.

@brycewang-microsoft brycewang-microsoft marked this pull request as draft November 9, 2022 20:37
@brycewang-microsoft brycewang-microsoft marked this pull request as ready for review November 9, 2022 23:28
@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brycewang-microsoft brycewang-microsoft merged commit 134c0ea into previews/v2 Nov 10, 2022
@brycewang-microsoft brycewang-microsoft deleted the brycewang/exception branch November 10, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants