Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ToJson() methods #2892

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Remove ToJson() methods #2892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions iothub/service/samples/getting started/EdgeDeploymentSample/EdgeDeploymentSample.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,11 @@ public async Task RunSampleAsync()
{
Console.WriteLine($"Created edge device {device.Id}");
Twin twin = await _serviceClient.Twins.GetAsync(device.Id);
Console.WriteLine($"\tTwin is {twin.ToJson()}");
Console.WriteLine($"\tTwin is {JsonSerializer.Serialize(twin)}");

twin.Tags[conditionPropertyName] = conditionPropertyValue;
await _serviceClient.Twins.UpdateAsync(device.Id, twin);
Console.WriteLine($"\tUpdated twin to {twin.ToJson()}");

Console.WriteLine();
Console.WriteLine($"\tUpdated twin to {JsonSerializer.Serialize(twin)}\n");
}

var baseConfiguration = new Configuration($"{ConfigurationIdPrefix}base-{Guid.NewGuid()}")
Expand Down
10 changes: 0 additions & 10 deletions iothub/service/src/Twin/Models/Twin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,6 @@ public Twin(TwinProperties twinProperties)
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
public virtual IReadOnlyList<string> ParentScopes { get; internal set; } = new List<string>();

/// <summary>
/// Gets the Twin as a JSON string.
/// </summary>
/// <param name="formatting">Optional. Formatting for the output JSON string.</param>
/// <returns>JSON string.</returns>
public string ToJson(Formatting formatting = Formatting.None)
drwill-ms marked this conversation as resolved.
Show resolved Hide resolved
{
return JsonConvert.SerializeObject(this, formatting);
}

/// <summary>
/// For use in serialization.
/// </summary>
Expand Down
10 changes: 0 additions & 10 deletions iothub/service/src/Twin/Models/TwinCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,6 @@ public DateTimeOffset GetLastUpdatedOnUtc()
return (long?)_metadata?[LastUpdatedVersionName];
}

/// <summary>
/// Gets the properties as a JSON string.
/// </summary>
/// <param name="formatting">Optional. Formatting for the output JSON string.</param>
/// <returns>JSON string.</returns>
public string ToJson(Formatting formatting = Formatting.None)
{
return JsonConvert.SerializeObject(JObject, formatting);
}

/// <summary>
/// Determines whether the specified property is present.
/// </summary>
Expand Down
10 changes: 0 additions & 10 deletions provisioning/service/src/Twin/Twin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,15 +172,5 @@ public Twin(TwinProperties twinProperties)
/// </remarks>
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
public virtual IReadOnlyList<string> ParentScopes { get; internal set; } = new List<string>();

/// <summary>
/// Gets the twin as a JSON string.
/// </summary>
/// <param name="formatting">Formatting for the output JSON string.</param>
/// <returns>JSON string</returns>
public string ToJson(Formatting formatting = Formatting.None)
{
return JsonConvert.SerializeObject(this, formatting);
}
}
}
10 changes: 0 additions & 10 deletions provisioning/service/src/Twin/TwinCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,16 +188,6 @@ public DateTime GetLastUpdatedOnUtc()
return (long?)_metadata?[LastUpdatedVersionName];
}

/// <summary>
/// Gets the TwinProperties as a JSON string.
/// </summary>
/// <param name="formatting">Optional. Formatting for the output JSON string.</param>
/// <returns>JSON string</returns>
public string ToJson(Formatting formatting = Formatting.None)
{
return JsonConvert.SerializeObject(JObject, formatting);
}

/// <summary>
/// Determines whether the specified property is present.
/// </summary>
Expand Down