Turn SDK log capturing off by default for E2E tests #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timtay-microsoft
approved these changes
Oct 24, 2022
abhipsaMisra
approved these changes
Oct 24, 2022
brycewang-microsoft
approved these changes
Oct 24, 2022
drwill-ms
force-pushed
the
drwill/sdk-logs-off-by-default
branch
from
9b365ff to
5f36b98
Compare
drwill-ms
force-pushed
the
drwill/sdk-logs-off-by-default
branch
from
5f36b98 to
011109f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK logs are nice but the tests that run concurrently put logs into each other's console output. As the logs come at a significant cost to running E2E tests in a pipeline and given that the logs aren't exclusive to each test, I'm turning collection off by default.
To turn them on, set an environment variable of
COLLECT_SDK_LOGStotrue.