-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in unrelated changes from STJ conversion attempt #3003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
force-pushed
the
drwill/misc-goodness
branch
from
December 5, 2022 21:33
0b691af
to
417dcf6
Compare
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
December 5, 2022 21:34
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
e2e/test/iothub/device/AzureSecurityCenterForIoTSecurityMessageE2ETests.cs
Show resolved
Hide resolved
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
iothub/device/tests/Authentication/ClientAuthenticationWithTokenRefreshTests.cs
Show resolved
Hide resolved
drwill-ms
commented
Dec 5, 2022
...ice/samples/how to guides/AutomaticDeviceManagementSample/AutomaticDeviceManagementSample.cs
Show resolved
Hide resolved
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
provisioning/device/samples/getting started/X509Sample/ProvisioningDeviceClientSample.cs
Show resolved
Hide resolved
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
commented
Dec 5, 2022
drwill-ms
force-pushed
the
drwill/misc-goodness
branch
2 times, most recently
from
December 5, 2022 22:38
7e5b2f0
to
3d93555
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
force-pushed
the
drwill/misc-goodness
branch
from
December 5, 2022 23:20
ac4dc36
to
a4bed04
Compare
timtay-microsoft
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
drwill-ms
force-pushed
the
drwill/misc-goodness
branch
from
December 5, 2022 23:36
377af40
to
3a9d1e5
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
commented
Dec 5, 2022
provisioning/device/src/Transports/Mqtt/ProvisioningTransportHandlerMqtt.cs
Show resolved
Hide resolved
abhipsaMisra
reviewed
Dec 5, 2022
drwill-ms
force-pushed
the
drwill/misc-goodness
branch
from
December 5, 2022 23:58
3a9d1e5
to
78752b0
Compare
abhipsaMisra
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
patilsnr
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.