-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create best practice solution sample using X.509 certificate authentication #3036
Merged
schoims
merged 19 commits into
previews/v2
from
choisophia/best-practice-solution-sample
Dec 29, 2022
Merged
Create best practice solution sample using X.509 certificate authentication #3036
schoims
merged 19 commits into
previews/v2
from
choisophia/best-practice-solution-sample
Dec 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schoims
commented
Dec 15, 2022
•
edited
Loading
edited
- Created best practice solution using X.509 certificate readme.md doc for .NET framework
- Created a script that generate test certificates, do proof-of-possession in DPS, and create a group enrollment in DPS.
- Created a script that cleans up a created device and group enrollment.
- Updated parameters in DeviceReconnectionSample to take certificate-related parameters.
- Improve X509Sample with exception handling, sdk stack trace log. Include an example how to set a RetryPolicy.
schoims
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
December 15, 2022 21:59
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
andyk-ms
reviewed
Dec 19, 2022
provisioning/device/samples/getting started/X509Sample/ProvisioningDeviceClientSample.cs
Outdated
Show resolved
Hide resolved
andyk-ms
reviewed
Dec 19, 2022
provisioning/device/samples/solutions/BestPracticeSampleX509/readme.md
Outdated
Show resolved
Hide resolved
andyk-ms
reviewed
Dec 19, 2022
andyk-ms
reviewed
Dec 19, 2022
provisioning/device/samples/solutions/BestPracticeSampleX509/readme.md
Outdated
Show resolved
Hide resolved
schoims
force-pushed
the
choisophia/best-practice-solution-sample
branch
from
December 27, 2022 18:39
8b883d3
to
1ef4c77
Compare
schoims
force-pushed
the
choisophia/best-practice-solution-sample
branch
from
December 27, 2022 18:42
1ef4c77
to
f848f89
Compare
andyk-ms
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed about the suggestion in details and assume they are updated.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
patilsnr
approved these changes
Dec 29, 2022
schoims
added a commit
that referenced
this pull request
Feb 5, 2023
…cation (#3036) * Work in progress * Update readme and projects * Combine scripts and update readme * Add parameters to DeviceReconnectionSample * Update X509 Sample * Update readme.md * Update Readme.md * Fix formatting * Add missing project * Format documents * Small update in readme * Add comments * Address comments * Update comments * Undelete * Update Reconnection Sample to create a device client using certificate * Add a write-up for retry policy * Update diagrams * Update diagrams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.