Added sample for Edge Module direct method #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmahmood-microsoft
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
ngastelum-ms,
patilsnr and
schoims
as code owners
|
You may also want to add the sample link here https://github.com/Azure/azure-iot-sdk-csharp/tree/previews/v2/iothub/device/samples#device-samples |
schoims
approved these changes
Jan 23, 2023
tmahmood-microsoft
changed the title
tmahmood-microsoft
changed the title
drwill-ms
approved these changes
Jan 24, 2023
schoims
suggested changes
Jan 24, 2023
iothub/device/samples/getting started/EdgeModuleMethodSample/Program.cs
Outdated
Show resolved
Hide resolved
| public class EdgeModuleMethodSample | ||
| { | ||
| private readonly IotHubModuleClient _moduleClient; | ||
| private string _deviceId; |
There was a problem hiding this comment.
Why are we not making deviceId and moduleId configurable?
There was a problem hiding this comment.
Trying to avoid asking more than necessary parameters from the user.
|
|
||
| case "WriteToConsole": | ||
| case "ModuleToModule": | ||
| return await WriteToConsoleAsync(directMethodRequest); |
There was a problem hiding this comment.
Is ModuleToModule necessary if it just writes to console?
There was a problem hiding this comment.
I wanted to distinguish between the two, since 'WriteToConsole' method prints out the method name.
schoims
reviewed
Jan 24, 2023
schoims
approved these changes
Jan 24, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EdgeModuleMethodSample.
This sample allows you to receive direct methods on Edge module from Azure portal and also from Edge module itself.
Also, updated repo for EdgeModuleMessageSample