Make Location property from DigitalTwinUpdateResponse internal #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoims
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tmahmood-microsoft
approved these changes
Feb 10, 2023
drwill-ms
reviewed
Feb 10, 2023
| @@ -34,6 +34,6 @@ protected internal DigitalTwinUpdateResponse(ETag eTag = default, string locatio | |||
| /// <summary> | |||
| /// Gets the URI of the digital twin. | |||
| /// </summary> | |||
| public string Location { get; } | |||
| internal string Location { get; } | |||
There was a problem hiding this comment.
Please add a comment as to why we're hiding this.
- No known use case for users.
- Only added to the service to be complete with guidance.
drwill-ms
approved these changes
Feb 10, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location property from DigitialTwinUpdateResponse is marked internal as there is no known use case from users and it was added to be complete with the guidance.