Feature/update tag name for dups v2 #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ohadbitt
reviewed
Oct 6, 2024
| props = SparkIngestionProperties.cloneIngestionProperties(ingestionProperties) | ||
| } | ||
| if (parameters.writeOptions.ensureNoDupBlobs) { | ||
| // if (blobIndexInBatch == 2 && TaskContext.get().taskAttemptId() % 2 == 0 && exceptionCount |
.scalafmt.conf
Outdated
| @@ -24,7 +24,7 @@ optIn = { | |||
| } | |||
| danglingParentheses.preset = false | |||
| docstrings.style = Asterisk | |||
| maxColumn = 98 | |||
| maxColumn = 120 | |||
There was a problem hiding this comment.
funny that now its the other way
| import java.util.concurrent.atomic.AtomicInteger | ||
| import scala.collection.JavaConverters.asScalaBufferConverter | ||
|
|
||
| object KustoWriter { | ||
| private val className = this.getClass.getSimpleName | ||
| private val exceptionCount = new AtomicInteger(0) |
| @@ -166,43 +170,47 @@ object KustoWriter { | |||
| tmpTableName = tmpTableName, | |||
| cloudInfo = cloudInfo) | |||
| val sinkStartTime = getCreationTime(stagingTableIngestionProperties) | |||
| // Cache this RDD created so that it is not evaluated multiple times from source | |||
| if (!props.getFlushImmediately && flushImmediately) { | ||
| props.setFlushImmediately(true) | ||
| } | ||
| val ingestClient = KustoClientCache |
There was a problem hiding this comment.
why do we need to get the client from cache everytime instead of passing it in params?
pom.xml
Outdated
| @@ -8,7 +8,7 @@ | |||
| <packaging>pom</packaging> | |||
| <version>${revision}</version> | |||
| <properties> | |||
| <revision>5.2.2</revision> | |||
| <revision>5.2.2-PREVIEW</revision> | |||
ohadbitt
reviewed
Oct 6, 2024
| } | ||
| } | ||
| if (parameters.writeOptions.ensureNoDupBlobs && taskMap.size() > 0) { | ||
| taskMap.forEach((blobUUID, blobWriter) => { |
There was a problem hiding this comment.
you dont use the blobUUID - revert to old usage
|
Supersceded with #404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[Add a description of your pull request here]
Future Release Comment
[Add description of your change, to include in the next release]
[Delete any or all irrelevant sections, e.g. if your change does not warrant a release comment at all]
Breaking Changes:
Features:
Fixes: