Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question/Feedback]: Stop deploying email action if the parameter is empty #126

Closed
1 task done
jaywithersbrewin opened this issue Feb 22, 2024 · 6 comments · Fixed by #161
Closed
1 task done

[Question/Feedback]: Stop deploying email action if the parameter is empty #126

jaywithersbrewin opened this issue Feb 22, 2024 · 6 comments · Fixed by #161
Assignees
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern question Further information is requested

Comments

@jaywithersbrewin
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

Hi!

If I omit ALZMonitorActionGroupEmail within policyAssignmentParametersNotificationAssets in alzArm.param.json (because I don't want notifications by email), then an email notification to [email protected] is still configured in the action group.

Is it possible to stop this from happening?

Thanks!

@jaywithersbrewin jaywithersbrewin added the question Further information is requested label Feb 22, 2024
@Brunoga-MS Brunoga-MS self-assigned this Feb 23, 2024
@Brunoga-MS
Copy link
Collaborator

Hello @jaywithersbrewin ,
thanks for your feedback. Could you please elaborate more on the reason why you would like to omit the ALZMonitorActionGroupEmail? is it because you only need other notification assets or because you really don't need any?

Thanks,
Bruno.

@jaywithersbrewin
Copy link
Author

hey @Brunoga-MS.

I only want to use ALZWebhookServiceUri.

Thanks!

@Brunoga-MS
Copy link
Collaborator

Perfect. I will investigate.

@jaywithersbrewin
Copy link
Author

Perfect. I will investigate.

Thanks!

@Brunoga-MS Brunoga-MS changed the title [Question/Feedback]: [Question/Feedback]: stop deploying email action if the parameter is empty Feb 23, 2024
@Brunoga-MS Brunoga-MS changed the title [Question/Feedback]: stop deploying email action if the parameter is empty [Question/Feedback]: Stop deploying email action if the parameter is empty Feb 23, 2024
@Brunoga-MS
Copy link
Collaborator

Hello @jaywithersbrewin ,
as a quick update, we are working on a solution to allow empty email address parameter so it will not deploy any email action with bogus addresses when not needed.

As soon as the code is ready, the merging of the corresponding PR will close this issue and you will get a notification.

Thanks,
Bruno.

@jaywithersbrewin
Copy link
Author

Hello @jaywithersbrewin , as a quick update, we are working on a solution to allow empty email address parameter so it will not deploy any email action with bogus addresses when not needed.

As soon as the code is ready, the merging of the corresponding PR will close this issue and you will get a notification.

Thanks, Bruno.

Hey, @Brunoga-MS. thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern question Further information is requested
Projects
None yet
2 participants