Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMBA - Allow Action Group to be created having the email NOT mandatory #161

Merged
merged 25 commits into from
Mar 20, 2024
Merged

AMBA - Allow Action Group to be created having the email NOT mandatory #161

merged 25 commits into from
Mar 20, 2024

Conversation

Brunoga-MS
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Allows the deployment of action group without forcing the bogus email address if email notification is not needed and resolves [Question/Feedback]: Stop deploying email action if the parameter is empty #126
  2. Update the related documentation

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS
Update Deploy-AlertProcessingRule-Deploy.json
de7fed8 
Allowing for no email value in the ALZMonitorActionGroupEmail parameter for Notification Assets
@Brunoga-MS
Update Deploy-ServiceHealth-ActionGroups.json
450acb3 
Allowing no email value for the ALZMonitorActionGroupEmail parameter for SH notification assets
@Brunoga-MS
Update alzArm.param.json
b5131d0 
Removing default value to allow no email action to be deployed for Notification Assets and SH notifications
@Brunoga-MS
Update Deploy-ServiceHealth-Alerts.json
6eca20e 
Removing default value to allow no email action deployment for Notification Assets and SH Notifications
@Brunoga-MS
Update Deploy-Notification-Assets.json
96b9483 
Removing default value to allow no email action deployment for Notification Assets and SH Notifications
@Brunoga-MS
Update Deploy-AlertProcessingRule-Deploy.json
0331d40 
Removing default value to allow no email action deployment for Notification Assets and SH Notifications
@Brunoga-MS
Update Deploy-ServiceHealth-ActionGroups.json
d8c7f27 
Removing default value to allow no email action deployment for Notification Assets and SH Notifications
@Brunoga-MS
Merge branch 'Azure:main' into noEmail
f6d793b
@Brunoga-MS
Fixing wrong copyIndex object
3f37da2
@Brunoga-MS
fixed empty param handling for email address
c2b7622
@Brunoga-MS
fixing the error on empty email
23b8b3d
@Brunoga-MS
Fixing wrong copyIndex instruction
c465d0c
@Brunoga-MS
removing comma that was invalidating the final policy file
d61a5eb
@Brunoga-MS
Aligning documentation to show sample email address using Microsoft f…
3d1d099 
…ictional companies
@Brunoga-MS
Adding a note for new not mandatory email
45836a3
@Brunoga-MS
fixing minor typos and formatting issues
8056c66
@Brunoga-MS
aligning policies.json with Main
1475134
@Brunoga-MS
Merge pull request #10 from Brunoga-MS/main
cce0134 
Updating noEmail with latest from Main
@Brunoga-MS
Updating policy version
11e71e5
@Brunoga-MS
Correcting versioning for policySetDefinitions and policyDefinitions
26768c0
@Brunoga-MS
Updating policies.json file
2d95a24
@Brunoga-MS
Merge branch 'Azure:main' into noEmail
6892733
@Brunoga-MS
Merge pull request #11 from Brunoga-MS/noEmail
26c867e 
Aligning Main with noEmail
@Brunoga-MS
Updating policies.json
06557bf
@Brunoga-MS Brunoga-MS requested a review from arjenhuitema March 18, 2024 10:51
@arjenhuitema
Copy link
Contributor

arjenhuitema commented Mar 20, 2024 •
edited
Loading

@Brunoga-MS LGTM. Would just like yo ask you to provide some deployment.

@Brunoga-MS
Copy link
Collaborator Author

@arjenhuitema: 10x ... you mean screenshots of deployment?

@arjenhuitema
Copy link
Contributor

Yes, a screenshot of the deployment, and a screenshot showing the changes that you made, in this case a successful deployment of the action groups without email address

@Brunoga-MS
Copy link
Collaborator Author

Here you go:

image

image

image

arjenhuitema
arjenhuitema approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit 590ea16 into Azure:main Mar 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question/Feedback]: Stop deploying email action if the parameter is empty
2 participants
@Brunoga-MS @arjenhuitema