Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bryanzab/us31386 #173

Merged
merged 16 commits into from
Apr 11, 2024
Merged

Bryanzab/us31386 #173

merged 16 commits into from
Apr 11, 2024

Conversation

bzabber
Copy link
Contributor

@bzabber bzabber commented Mar 22, 2024

Overview/Summary

Updated the AMBA-ALZ Diagrams to include the new notification assets initiative and Action group options and cleaned up the lines a bit to make it more readable.

This PR fixes/adds/changes/removes

  1. Include Notification Assets Initiative in diagram in amba-policy-initiative-flow diagram in Introduction-to-deploying-the-ALZ-Pattern
  2. AMBA-focused-rg-alz-monitor-alert-flow diagram to include new Action Group options. file version was updated to v3. This appears in the Monitoring-and-Alerting page.
  3. Cleaned up the lines in amba-policy-initiative-flow diagram to make the diagram easier to read.

Breaking Changes

None

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS Brunoga-MS added the documentation Improvements or additions to documentation label Mar 27, 2024
@Brunoga-MS Brunoga-MS requested a review from arjenhuitema April 4, 2024 10:31
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit dd0d69c into Azure:main Apr 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants