Fixing compliance evaluation issues

[Brunoga-MS]

Overview/Summary

The compliance evaluation for the following alerts is not evaluated correctly despite the corresponding alerts were created correctly:

• Deploy KeyVault Requests Alert
• Deploy VNetG Ingress Packet Drop Mismatch Alert
• Deploy VNetG Ingress Packet Drop Count Alert
• Deploy VNetG Egress Packet Drop Mismatch Alert
• Deploy VNetG Egress Packet Drop Count Alert

Reason why, is a wrong value for the minFailingPeriodsToAlert and numberOfEvaluationPeriods fields.

After correction, with a simple AMBA re-deployment and without running the remediation again if already executed, the resources appear compliant

Remediation tasks for alerts Deploy AGW BackendLastByteResponseTime and Deploy AGW ApplicationGatewayTotalTime are failing see GH Issue #194) because the value for timeAggregation is set to Total which is not allowed. Allowed values are Average and Maximum as per error message:

{"code":"BadRequest","message":"Time aggregation must be one of [Average, Maximum]. Activity ID: 2f08dc2e-10ce-470c-ae4a-5686252aaedc."}

Given the alerts being using dynamic thresholds, changing the value to Average, will make the remediation tasks successful:

This PR fixes/adds/changes/removes

1. Changes the value of field minFailingPeriodsToAlert and numberOfEvaluationPeriods in the existenceCondition for the above alerts from 2 to 4 to fix the compliance evaluation issue. This is related to the following bugs in ADO #34468 and #34469
2. *Changes the value of timeAggregation to Average for both Deploy AGW BackendLastByteResponseTime and Deploy AGW ApplicationGatewayTotalTime policy definitions. See GH Issue [Question/Feedback]: AGW Alert Deploy Failed for "Deploy AGW BackendLastByteResponseTime" and “Deploy AGW ApplicationGatewayTotalTime”  #194 and ADO bug #34697 *

Breaking Changes

1. NONE

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Ensured PR tests are passing
• Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

[arjenhuitema]

LGTM