Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Hybrid alerts #212

Merged
merged 133 commits into from
May 30, 2024
Merged

Adding Hybrid alerts #212

merged 133 commits into from
May 30, 2024

Conversation

Brunoga-MS
Copy link
Collaborator

@Brunoga-MS Brunoga-MS commented May 13, 2024 •
edited
Loading

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Adds necessary parameters for UAMI and hybrid alerts

image

  1. Creates an UAMI in the Management subscription or uses a customer defined one
image
  1. Moves the BYON parameters into the Notification block to optimize the places where customer are supposed to operate changes

image

  1. Adds a specific parameter block for LZ Hybrid (using the same values from LZ for Compute/virtualMachines alerts)
image
  1. Deploys a LZ-Hybrid initiative containing all the hybrid alerts. To read ARG the alerts will use either the AMBA UAMI or the customer defined one

image

  1. Deploys 12 policy definitions for alerts contained inthe LZ Hybrid policy initiatives

image

image

  1. Fix a parameter mapping on the Compute/virtualMachines alerts

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Brunoga-MS added 30 commits April 16, 2024 14:21
@Brunoga-MS
testing ResourceGraph alerts
b19561f
@Brunoga-MS
Testing Arg alert for disconnected HybridVM
32c171a
@Brunoga-MS
Fixing parameters and alert template
f78b076
@Brunoga-MS
Adding uami to the alert template
829fae7
@Brunoga-MS
fixing template default values
15ef306
@Brunoga-MS
Fixing wrong parameter association
a0d5027
@Brunoga-MS
Fixing missing location param at deployment scope
1e264e2
@Brunoga-MS
Fixing allowed values and default values for HybridVMDisconnectedWind…
cc2acae 
…owSize
@Brunoga-MS
fixing wrong parameter value
7833092
@Brunoga-MS
Fixing parameter name in policy assignment for the new policy definition
e508481
@Brunoga-MS
Fixing typo in parameter name
7d048f0
@Brunoga-MS
Fixing typo in parameter name
ac8587a
@Brunoga-MS
fixing wrong param reference on VM alerts
94d10ed
@Brunoga-MS
Fixing default values for params
c6936e8
@Brunoga-MS
Fixing dimension name
ae9395e
@Brunoga-MS
Fixing query and parameter file
82598a9
@Brunoga-MS
adding uami deployment through arm template
75ff226
@Brunoga-MS
Changing parameter structure to avoind passing where not needed
02b3e36
@Brunoga-MS
Fixing wrong parameter reference
f60aa42
@Brunoga-MS
Fixing syntax error in alzArm.json
2531944
@Brunoga-MS
Adding apiVersion to reference for MI principalId
309e369
@Brunoga-MS
Fixed parameters' default and description
3a2b7f5
@Brunoga-MS
changed template to not call linked templates for ARG stuff
64a2efb
@Brunoga-MS
fixed param reference
c734b3c
@Brunoga-MS
Fixing schema and moving subscription param
46fde9d
@Brunoga-MS
moved back to linked templates and fixed syntax for passing parameter…
8442781 
… values
@Brunoga-MS
converted parameter object to string
3560d18
@Brunoga-MS
adding .value property to parameter value passage
b5ce5f9
@Brunoga-MS
passing params in different way for RG
7c49a4b
@Brunoga-MS
changed param structure for RG
5ca2993
@Brunoga-MS Brunoga-MS requested a review from arjenhuitema May 13, 2024 15:49
Brunoga-MS
Brunoga-MS commented May 18, 2024
View reviewed changes
Copy link
Collaborator Author

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Brunoga-MS
Brunoga-MS commented May 18, 2024
View reviewed changes
Copy link
Collaborator Author

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Brunoga-MS
Brunoga-MS commented May 18, 2024
View reviewed changes
Copy link
Collaborator Author

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit 72bbd25 into Azure:main May 30, 2024
2 of 3 checks passed
@Brunoga-MS Brunoga-MS deleted the arg-Alerts branch August 29, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brunoga-MS @arjenhuitema