Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor disable parameters #246

Merged

Conversation

Brunoga-MS
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Replace the MonitorDisable static tag with the flexible couple ALZMonitorDisableTagName and ALZMonitorDisableTagValues (which is an array of possible values. workitem 35029
  2. Ensure the Policy Effect is present and used by any policyDefinition workitem 35180
  3. Split the policy.json by generating a dedicated one for hybrivdVM given the limitation on file size
  4. Removes the unnecessary granular parameters for DiskToInclude and NetworkInterfaceToInclude. This was necessary to not incur in the limit of 20 params per policyDefinition
  5. Adds documentation about the new MonitorDisable approach
  6. Standardize the default value for resource group to "rg-amba-monitoring-001" (documentation also updated in this one)
  7. New documentation page for updating from previous release [2024-06-05[(https://github.com/Azure/azure-monitor-baseline-alerts/releases/tag/2024-06-05)
  8. Reneme 4 unused policyDefinitions by prefixing with Not_In_Use:
    • Not_In_Use_Deploy-VM-AvailableMemory-Alert
    • Not_In_Use_Deploy-VM-HeartBeatAlertRG
    • Not_In_Use_Deploy-Hybrid-VM-AvailableMemory-Alert
    • Not_In_Use_Deploy-Hybrid-VM-HeartBeatAlertRG

IMAGES OF WHAT IS DEPLOYED AND REMEDIATED

image
image
image
image
image
image

Breaking Changes

  1. Since existing parameters cannot be changed or removed, the update from previous releases requires the execution of a script to remove existing policy definitions, policy set definitions, policy assignments and role assignments before starting the deployment. This is also documented in the new Updating from release 2024-06-05 page

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • [C] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Brunoga-MS added 30 commits May 9, 2024 23:21
@arjenhuitema arjenhuitema added enhancement New feature or request Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Jun 21, 2024
@arjenhuitema arjenhuitema self-assigned this Jun 26, 2024
@arjenhuitema arjenhuitema changed the base branch from main to dev-alz-pattern July 1, 2024 09:32
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit 74818ac into Azure:dev-alz-pattern Jul 1, 2024
1 check passed
@Brunoga-MS Brunoga-MS deleted the monitorDisableParameters branch August 29, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy enhancement New feature or request Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
2 participants