Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert for daily data capping limit reached for Log Analytics workspaces #259

Merged
merged 22 commits into from
Jul 4, 2024

Conversation

Brunoga-MS
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Changes the alzArm.json by adding the passage of UAMI param to Management initiative
  2. Optimizes the logic for PID choice based on the deployment method (ARM or AMBA Portal Accelerator)
  3. Adds new parameters to the alzArm.params.json according to the new policyDefinition
  4. Adds the new policyDefinition to the policySetDefinition file Deploy-Management-Alerts.json
  5. Updates the policies.bicep with the new policyDefinition file
  6. Adds the new policyDefinition services/OperationalInsights/workspaces/Deploy-LAWorkspace-DailyCapLimitReached-Alert.json

All the above is related to User Story AMBA - Add alert for daily data capping limit reached for Log Analytics workspaces

image image image

image

Breaking Changes

  1. NONE (compare to hose already in the dev branch)
  2. Replace me

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [] Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Brunoga-MS added 18 commits July 2, 2024 14:59
…T5M as the default value for evaluationFrequency
…T5M as the default value for evaluationFrequency
@Brunoga-MS Brunoga-MS requested a review from arjenhuitema July 3, 2024 11:14
@arjenhuitema arjenhuitema self-assigned this Jul 3, 2024
@arjenhuitema arjenhuitema added Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Jul 3, 2024
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit bc20392 into Azure:dev-alz-pattern Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants