Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing latency alert display name #263

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Fixing latency alert display name #263

merged 5 commits into from
Jul 5, 2024

Conversation

Brunoga-MS
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Fixes the displayname together with existenceCondition for the latency and space alerts for both Azure and Hybrid VMs as per GH ISSUE 261

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS Brunoga-MS requested a review from arjenhuitema July 4, 2024 16:52
@arjenhuitema arjenhuitema self-assigned this Jul 5, 2024
@arjenhuitema arjenhuitema added Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Jul 5, 2024
arjenhuitema
arjenhuitema approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Brunoga-MS

@arjenhuitema arjenhuitema merged commit 551f491 into Azure:dev-alz-pattern Jul 5, 2024
1 check passed
This was linked to issues Jul 17, 2024
Feedback: No treshold parameter for ALZ alerts #260
Closed
[Question/Feedback]: displayname VMLowOSDisk(Write/Read)LatencyAlert should be VMHighOSDisk(Write/Read)LatencyAlert #261
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees

@arjenhuitema arjenhuitema

Labels
Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Milestone
No milestone
2 participants
@Brunoga-MS @arjenhuitema