Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligning Dev branch with threshold override dev branch #290

Merged
merged 70 commits into from
Jul 29, 2024
Merged

Aligning Dev branch with threshold override dev branch #290

merged 70 commits into from
Jul 29, 2024

Conversation

Brunoga-MS
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. *Changes all the metrics and log alerts to work with a threshold override tag as per *
  2. Add missing failingPeriods param to alerts (see ADO WorkItem 36357 and GH Issue #177

Breaking Changes

  1. NONE .... Just those already discussed

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Brunoga-MS added 30 commits July 17, 2024 22:00
@Brunoga-MS
refactor: Update Hybrid VM Disconnected alert threshold values and pa…
abae75d 
…ram name and definition
@Brunoga-MS
Updated documentation with 2 new known issues
9092d9a
@Brunoga-MS
Fixing rendering issue
6175ab1
@Brunoga-MS
Merge branch 'dev-alz-pattern' into dev-alz-pattern
6be0c54
@Brunoga-MS
Merge branch 'Azure:dev-alz-pattern' into dev-alz-pattern
1cbf80f
@Brunoga-MS
docs: Update Azure resource naming rules and restrictions
f9a7c9f
@Brunoga-MS
Reverting documentation change since it will go directly to main
44013c6
@Brunoga-MS
Reverting Known-Issues
9b68139
@Brunoga-MS
Merge branch 'Azure:dev-alz-pattern' into dev-alz-pattern
2aa2adf
@Brunoga-MS
Testing thresholdoverride tag on totalJob hybridDisconnected and hybr…
90e1d38 
…idDataReadlatency alerts
@Brunoga-MS
refactor: Update default values for HybridVMDisconnectedAlertOperator
a12c62f
@Brunoga-MS
feat: Update default values for HybridVMDisconnectedAlertOperator
77ff8b3
@Brunoga-MS
refactor: Update defaultValue for HybridVMDisconnectedEvaluationFrequ…
4c88897 
…ency
@Brunoga-MS
refactor: Update default timeAggregation default value for datadisk r…
1c48c56 
…ead latency
@Brunoga-MS
renamed query field
9088a10
@Brunoga-MS
refactor: Update default values for timeAggregation in alert configur…
5f2f90e 
…ations
@Brunoga-MS
refactor: Update default values for timeAggregation in alert configur…
92ff732 
…ations
@Brunoga-MS
refactor: Restored default values for timeAggregation in hybrid DataD…
e59854c 
…iskSpace alert configurations
@Brunoga-MS
refactor: Fixing query syntax
fa99c3d
@Brunoga-MS
refactor: Update query syntax for HybridVM DataDiskReadLatency alert
c07974a
@Brunoga-MS
refactor: Update default values for timeAggregation in Data Disk spac…
f93c764 
…e alert configurations
@Brunoga-MS
refactor: Update query syntax for HybridVM DataDiskReadLatency alert
99bcd80
@Brunoga-MS
refactor: Update query syntax for HybridVM DataDiskReadLatency alert
8fd39a2
@Brunoga-MS
refactor: Adding overridethreshold to hybridvm data write latency
f2ea162 
Fixed existenceCondition for Disconnected, data read latency and data disk space
@Brunoga-MS
refactor: Update query syntax for HybridVM DataDiskRead/WriteLatency …
4781325 
…alert
@Brunoga-MS
refactor: Update query syntax for HybridVM Heartbeat alert
6cc1550
@Brunoga-MS
refactor: Update query syntax for HybridVM Heartbeat alert
90cb893
@Brunoga-MS
refactor: Update query syntax for HybridVM Heartbeat alert
aa7cce0
@Brunoga-MS
refactor: Update query syntax for HybridVM Heartbeat alert
49e1d65
@Brunoga-MS
refactor: Update query syntax for HybridVM Heartbeat and Disconnected…
1fd166d 
… alerts
Brunoga-MS added 18 commits July 26, 2024 18:09
@Brunoga-MS
chore: Update VMNetworkInTimeAggregation with thresholdOverride Tag
b2e336b
@Brunoga-MS
chore: Update VMNetworkOut alert with thresholdOverride tag
2cf335c
@Brunoga-MS
Update VMOSDiskReadLatency alert with overrideThreshold tag
b496639
@Brunoga-MS
chore: Update VMOSDiskSpace alert with thresholdOverride tag
3c0b62f
@Brunoga-MS
Update VMOSDiskWriteLatency alert with thresholdOverrideTag
6acfacd
@Brunoga-MS
Update VMPercentCPU alert with threshldOverride tag
5b99778
@Brunoga-MS
chore: Update VMPercentMemory with thresholdOverrideTag
6d6881a
@Brunoga-MS
chore: Update alert thresholds with override tags
1f4c123
@Brunoga-MS
chore: Update VMPercentCPUTimeAggregation default and allowed values
f26b9ac
@Brunoga-MS
chore: Update VMDataDiskSpaceFailingPeriods parameter in policy defin…
167cc55 
…itions and policy set definitions
@Brunoga-MS
chore: Update VMDataDiskSpaceFailingPeriods parameter in policy defin…
0a3ec67 
…itions and policy set definitions
@Brunoga-MS
chore: Update VMHeartBeatRGFailingPeriods parameter in policy definit…
f44ce23 
…ions and policy set definitions
@Brunoga-MS
chore: Update alert thresholds with override tags
fcbc936
@Brunoga-MS
chore: policy* files
9bbd2c4
@Brunoga-MS
chore: Update policy set definitions with MonitorDisableTagName and M…
7407c29 
…onitorDisableTagValues
@Brunoga-MS
chore: Fixed policy set definitions with correct param name for VMPer…
aa9ca44 
…centMemoryFailingPeriods
@Brunoga-MS
chore: Update VMPercentMemoryFailingPeriods parameter in policy defin…
966bc2c 
…itions and policy set definitions
@Brunoga-MS
chore: Update queries with the correct case for type
27cefcf
@Brunoga-MS Brunoga-MS requested a review from arjenhuitema July 29, 2024 14:55
This was linked to issues Jul 29, 2024
Can we add a Parameter to adjust "Number of Violations" #177
Closed
[Question]: How to override the default alert threshold values for specific resource names? #272
Closed
This was unlinked from issues Jul 29, 2024
Can we add a Parameter to adjust "Number of Violations" #177
Closed
[Question]: How to override the default alert threshold values for specific resource names? #272
Closed
@arjenhuitema arjenhuitema added Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Jul 29, 2024
@arjenhuitema arjenhuitema self-assigned this Jul 29, 2024
arjenhuitema
arjenhuitema approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit b1305b9 into Azure:dev-alz-pattern Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees

@arjenhuitema arjenhuitema

Labels
Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brunoga-MS @arjenhuitema