Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Application Insights alerts #314

Merged
merged 43 commits into from
Dec 20, 2024
Merged

Conversation

ymehdimsft
Copy link
Contributor

@ymehdimsft ymehdimsft commented Aug 28, 2024

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

Adds 2 alerts (App Insights Throttling limit reached, App Insights Delete) as per ADO work items #35145 and #36469

Deployment results:

image image

Remediation results:

image image image

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

ymehdimsft and others added 26 commits August 1, 2024 16:17
troubleshooting failing remediation
Update Deploy-AppInsightsThrottlingLimit-Alert.json
Update Deploy-ActivityLog-AppInsights-Del.json
Update Deploy-AppInsightsThrottlingLimit-Alert.json
Refining query to return only records for the selected AppInsights resource
Update Deploy-AppInsightsThrottlingLimit-Alert.json
@arjenhuitema arjenhuitema self-assigned this Aug 29, 2024
@arjenhuitema arjenhuitema added Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Aug 29, 2024
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ymehdimsft

Let's work on making the following changes:

  1. These resource types typically dont exist under the Management management group. Therefore we should include these policies not in the Management Initiative. As this regards App Insights it makes sense to add them to the Web Initiative.
  2. The policies.bicep will no longer be used, and shouldn't be modified anymore and it will be removed in the near future.

patterns/alz/alzArm.param.json Outdated Show resolved Hide resolved
patterns/alz/templates/policies-Monitoring.bicep Outdated Show resolved Hide resolved
patterns/alz/templates/policies.bicep Outdated Show resolved Hide resolved
@arjenhuitema arjenhuitema changed the base branch from dev-alz-pattern to main September 2, 2024 08:12
@Brunoga-MS Brunoga-MS self-requested a review December 17, 2024 18:18
@Brunoga-MS Brunoga-MS self-assigned this Dec 17, 2024
Copy link
Contributor Author

@ymehdimsft ymehdimsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments adressed

@Brunoga-MS Brunoga-MS changed the title Dev alz pattern Add Application Insights alerts Dec 19, 2024
Brunoga-MS
Brunoga-MS previously approved these changes Dec 20, 2024
Copy link
Collaborator

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brunoga-MS Brunoga-MS dismissed arjenhuitema’s stale review December 20, 2024 17:13

comments were addressed

@Brunoga-MS Brunoga-MS merged commit fcebd2f into Azure:main Dec 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants