Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMBA Update diagrams #325

Merged
merged 6 commits into from
Sep 17, 2024
Merged

AMBA Update diagrams #325

merged 6 commits into from
Sep 17, 2024

Conversation

ymehdimsft
Copy link
Contributor

@ymehdimsft ymehdimsft commented Sep 6, 2024 •
edited by arjenhuitema
Loading

Overview/Summary

This PR replaces AMBA diagrams's visio file and images in the "Introduction to deploying the ALZ Pattern" page of the documentation

This PR fixes/adds/changes/removes

  1. Replaces AMBA diagrams with the lastest changes related to new release
  2. Replaces images of the diagrams in the documentation

Breaking Changes

None

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

arjenhuitema
arjenhuitema requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ymehdimsft. I sent you a few minor tweaks bilaterally that we should review.

@arjenhuitema arjenhuitema self-assigned this Sep 6, 2024
@arjenhuitema arjenhuitema added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Sep 6, 2024
@ymehdimsft
Copy link
Contributor Author

Changes corrected, diagrams updated and verified.

arjenhuitema
arjenhuitema approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ymehdimsft

@arjenhuitema arjenhuitema merged commit 6ee58c7 into Azure:main Sep 17, 2024
3 of 4 checks passed
@arjenhuitema arjenhuitema changed the title User story 36201: AMBA Update diagrams AMBA Update diagrams Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees

@arjenhuitema arjenhuitema

Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymehdimsft @arjenhuitema