Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts ASR Modify Policy #334

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Alerts ASR Modify Policy #334

merged 6 commits into from
Sep 30, 2024

Conversation

roarrioj
Copy link
Contributor

@roarrioj roarrioj commented Sep 13, 2024

Overview/Summary

Configuring recovery services vaults to enable Azure Monitor for Azure Site Recovery.

This PR fixes/adds/changes/removes

  1. NEW: Policy to audit/update Recovery Vault ASR Health Alerting to Azure monitor alerts
  2. Update: Added new RSV policy to Management Initiative
  3. Update: Added new RSV policy to Recovery Services Initiative
  4. Update: Parameter file with new parameters
  5. Update: Recovery Services template file

Breaking Changes

N/A

Evidence

Non compliant:
image

Remediation:
image

image

Compliance:
image

Monitoring Settings:

        "monitoringSettings": {
            "azureMonitorAlertSettings": {
                "alertsForAllJobFailures": "Enabled",
                "alertsForAllReplicationIssues": "Enabled",
                "alertsForAllFailoverIssues": "Enabled"
            },
            "classicAlertSettings": {
                "alertsForCriticalOperations": "Disabled",
                "emailNotificationsForSiteRecovery": "Disabled"
            }
        },

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@roarrioj roarrioj changed the title Asr Alerts ASR Modify Policy Sep 13, 2024
@arjenhuitema arjenhuitema self-assigned this Sep 13, 2024
@arjenhuitema arjenhuitema added Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Sep 13, 2024
@Brunoga-MS
Copy link
Collaborator

Hi @roarrioj ,
thanks for your effort; the PR looks good enough. However, It would be great if you could provide some details about what is in and evidence of changes and of successful testing.

After this last mile, we could go ahead and merge it.

Thanks,
Bruno.

Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @roarrioj

@arjenhuitema arjenhuitema merged commit 0adf51a into Azure:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants