Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action to validate yml schemas #434

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

jfaurskov
Copy link
Contributor

Overview/Summary

Add code to validate alert yaml schema on PR. Task is described in https://dev.azure.com/CSUSolEng/Guidance%20-%20Observability/_workitems/edit/37696

This PR fixes/adds/changes/removes

  1. Adds Github action .github/workflows/validate-yml-schema.yml, which will trigger on PR.
  2. Adds .github/yml-schemas directory containing the default yml schemas for the various alert types.

Breaking Changes

May cause previously accepted yml files to be rejected if changes are made since they are not meeting requirements.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jfaurskov jfaurskov marked this pull request as ready for review November 26, 2024 13:53
@jfaurskov jfaurskov requested a review from judyer28 November 26, 2024 13:54
@judyer28
Copy link
Collaborator

@jfaurskov, please fix errors raised by lint checks.

Copy link
Collaborator

@judyer28 judyer28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Jan!

@judyer28 judyer28 merged commit 08d9357 into Azure:main Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants