Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evaluationPeriods naming #468

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: evaluationPeriods naming #468

merged 1 commit into from
Dec 19, 2024

Conversation

arjenhuitema
Copy link
Contributor

Overview/Summary

alzlibtool flagged naming inconsistencies of evaluationPeriods

image

This PR fixes/adds/changes/removes

  1. Fix casing of evaluationPeriods

Breaking Changes

None

Evidence

Deployment:

image

Policy:

image

Fixing the casing of evaluationPeriods in the library fixed the error

image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@arjenhuitema arjenhuitema added Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern labels Dec 18, 2024
Brunoga-MS
Brunoga-MS approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brunoga-MS Brunoga-MS merged commit 775e1fe into main Dec 19, 2024
3 of 4 checks passed
@arjenhuitema arjenhuitema deleted the patch-alzlibsync branch December 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brunoga-MS Brunoga-MS Brunoga-MS approved these changes

Assignees
No one assigned
Labels
Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arjenhuitema @Brunoga-MS