Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arg query optimization #484

Merged
merged 18 commits into from
Jan 17, 2025
Merged

Arg query optimization #484

merged 18 commits into from
Jan 17, 2025

Conversation

Brunoga-MS
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Replaces all Azure and Hybrid VM alert queries that use ARG with an optimized version that call ARG only once per query [General workload issue]: Query is throttled API limitation #469

Breaking Changes

  1. NONE

Testing evidence

NEW DEPLOYMENT
image

UPDATE ON EXISTING DEPLOYMENT
image

REMEDIATION
image

COMPLIANCE
image

ALERTS
image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS
testing new optimized query on DataDiskReadLatency
19697c2
@Brunoga-MS
Optimizing ARG part of the query on all VM alerts
c9ca21d
@Brunoga-MS
applied query optimization to hybridVM policies
5cae6a6
@Brunoga-MS
Fixed wrong overridetag value
aaa6a85
@Brunoga-MS
Fixing wrong resource type for hybrid machine alerts
4438901
@Brunoga-MS
fixed eol
13afca2
@Brunoga-MS
Fixing hybridVM alert policy
e8330c5
@Brunoga-MS
Fixing query azure VM alerts
e8e2f72
@Brunoga-MS
Updating display names fo policy and policySet definitions
826d5f3
@Brunoga-MS
Fixing resource tag conditions in aalert queries for hybrid and virtu…
2fc52ca 
…al machines
@Brunoga-MS
Fixed display and version for policySetDefinition for Azure and Hybri…
0ff67b0 
…d VMs
@Brunoga-MS
Updating CRLF
6106097
@Brunoga-MS
Updating displayname on dine assignment for both azure and Hybrid VMs
fe12b48
@Brunoga-MS
Fixing wrong syntax in hybridvm alert queries
7d6908b
@Brunoga-MS
Fixing resource tag conditions in heartbeat and CPU alert queries for…
5a873ad 
… virtual machines
@Brunoga-MS
Merge branch 'Azure:main' into argQueryOptimization
c7a91fe
@Brunoga-MS Brunoga-MS added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Jan 14, 2025
@Brunoga-MS Brunoga-MS requested a review from tagolovina January 14, 2025 19:11
tagolovina
tagolovina previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@tagolovina tagolovina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

tagolovina
tagolovina approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@tagolovina tagolovina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Brunoga-MS Brunoga-MS merged commit fce1191 into Azure:main Jan 17, 2025
3 of 4 checks passed
@Brunoga-MS Brunoga-MS deleted the argQueryOptimization branch January 17, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tagolovina tagolovina tagolovina approved these changes

Assignees
No one assigned
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brunoga-MS @tagolovina @tgolovina