Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setupdri #485

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Setupdri #485

merged 4 commits into from
Jan 22, 2025

Conversation

alisakina99
Copy link
Contributor

@alisakina99 alisakina99 commented Jan 15, 2025

Overview/Summary

Creation of a CODEOWNERS file to set up initial DRI for AMBA

This PR fixes/adds/changes/removes

  1. adds CODEOWNERS file

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure of the file looks good! Looks like Shweta also wants to you add Hannah as the VMI directory owner as well just as a heads up. Also, it looks like the amba-maintainers team may need to have their priviledges bumped up which @judyer28 can help with:

image

.github/CODEOWNERS Outdated Show resolved Hide resolved
@judyer28
Copy link
Collaborator

@alisakina99 @oZakari I added amba-maintainers and aprl-maintainers. Let me know if anything else is needed.

@alisakina99 alisakina99 requested a review from oZakari January 17, 2025 15:48
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oZakari oZakari merged commit ee8bdae into Azure:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants