-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added guide to only deploy service health #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes - we need to
- Determine upper or lowercase for initiatives
- Use of Policy Set Definition or Initiative
docs/content/patterns/alz/deploy/Deploy-only-Service-Health-Alerts.md
Outdated
Show resolved
Hide resolved
docs/content/patterns/alz/deploy/Deploy-only-Service-Health-Alerts.md
Outdated
Show resolved
Hide resolved
docs/content/patterns/alz/deploy/Deploy-only-Service-Health-Alerts.md
Outdated
Show resolved
Hide resolved
docs/content/patterns/alz/deploy/Deploy-only-Service-Health-Alerts.md
Outdated
Show resolved
Hide resolved
…erts.md Co-authored-by: Paul Grimley <[email protected]>
…erts.md Co-authored-by: Paul Grimley <[email protected]>
…erts.md Co-authored-by: Paul Grimley <[email protected]>
@arjenhuitema: documentation looks great 👍 Just few comments:
|
Thanks @Brunoga-MS ! Made changes to address points 2 and 3. I will keep point 1 as is. It´s consistent with the other deployment guides and we don´t want to assume what terminal is being used to run Azure CLI. I run Azure CLI from a PowerShell terminal, however I know others that run Azure CLI from Bash (Cloud Shell) On point 4. We can´t, the existing parameter file contains all of the parameters used for a full deployment. Using the parameter file for deploying the Policy Set Assignment wil result in a template violation, as there will be parameters that are being supplied but don´t exist in the template that is deployed. Of course a customer could create their own parameter file from the JSON string in the command provided. For now, I will leave this as is, if in the future there are requests to provide an Arm template, or parameter file for this specific scenario we can evaluate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
Added guidance for deploying only the service health alerts.
This PR fixes/adds/changes/removes
Breaking Changes
N/A
As part of this Pull Request I have
main
branch