Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lz2alerts #57

Merged
merged 25 commits into from
Nov 3, 2023
Merged

Lz2alerts #57

merged 25 commits into from
Nov 3, 2023

Conversation

Alboroni
Copy link
Contributor

@Alboroni Alboroni commented Oct 26, 2023 •
edited
Loading

Overview/Summary

Addition of Landing Zone Alerts coving Traffic Manager, Frontdoor, s and App Service plan base alerts t o the LZ initiative

This PR fixes/adds/changes/removes

  1. Adds 14 new alert files
  2. Updates patterns\alz\policySetDefinitions\Deploy-LandingZone-Alerts.json with new alerts

Breaking Changes

  1. None but adding more parameters to LZ initiative
  2. Replace me

As part of this Pull Request I have

  • [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [x ] Checked for duplicate Pull Requests
  • [ x] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.) (to be done in separate request)

Alboroni
Alboroni commented Nov 2, 2023
View reviewed changes
Copy link
Contributor Author

@Alboroni Alboroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@Alboroni Alboroni marked this pull request as ready for review November 2, 2023 11:02
@Alboroni Alboroni requested a review from arjenhuitema November 2, 2023 13:55
arjenhuitema
arjenhuitema previously approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Deployment is ok.
image

Remediation works and alerts are created:

App Service
image

Front door (classic)
image

Front door (cdn profile)
image

Traffic manager
image

@arjenhuitema
Copy link
Contributor

@Alboroni everything's good, just need to resolve the merge conflict.

@arjenhuitema arjenhuitema added the enhancement New feature or request label Nov 3, 2023
@Alboroni Alboroni self-assigned this Nov 3, 2023
arjenhuitema
arjenhuitema approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit 5d8dff0 into Azure:main Nov 3, 2023
@Alboroni Alboroni deleted the LZ2alerts branch May 3, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees

@Alboroni Alboroni

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alboroni @arjenhuitema