Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving release into build yml #696

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Moving release into build yml #696

merged 8 commits into from
Jun 3, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented May 30, 2024

Hey openap-validator folks! This PR should only make your lives easier. I'm not changing anything other than adding a release stage to our build yml. The reason I'm doing this is because we going after the long-tail of builds that cannot be converted to 1es-templates-compatible. The staging and prod releases to NPM for azure-openapi-validator need to be removed, but we also need to be certain you can still ship new versions of the package!

This PR will make it so that your prod and staging builds will also include approvable releases to npm.

In a nutshell, when you queue Staging or Production pipeline, you will immediately get an approvable release stage. Have to kick the pipeline manually to get the release stage.

image

Prod stage will be labeled release latest. These are also the tags that are set on the ERSP release.

todo:

Submitting this PR early to understand which CI will actually trigger.

Can one of the openapivalidator devs please confirm the two sets of artifacts on each linked release under the Test a release checkbox? Would I break anyone if I actually released a new version of the package?

@scbedd scbedd marked this pull request as ready for review May 31, 2024 23:37
@scbedd scbedd merged commit 8058c85 into main Jun 3, 2024
4 checks passed
@scbedd scbedd deleted the add-npm-release branch June 3, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants