Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eng]: CI check whether SDK was generated not functioning properly #22875

Closed
VeryEarly opened this issue Sep 28, 2023 · 2 comments
Closed

[Eng]: CI check whether SDK was generated not functioning properly #22875

VeryEarly opened this issue Sep 28, 2023 · 2 comments
Labels
Engineering

Comments

@VeryEarly
Copy link
Collaborator

Description

track 1 SDK with manual changes were able to pass CI.
For example:
#22637

CI should be able to block such changes.
@isra-fel
Copy link
Member

isra-fel commented Oct 8, 2023

We should try modifying a generated file and submit a PR to verify the check.
Also check if the check supports sdk generated by autorest.powershell

@isra-fel
Copy link
Member

@NoriZC please try to reproduce this issue, and discuss the plan of checking SDKs generated by a.p.

@NoriZC NoriZC mentioned this issue Oct 13, 2023
Merged
1 task
@NoriZC NoriZC closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isra-fel @VeryEarly @NoriZC