Adding Autoscaling Capabilities to Virtual Network Gateway #22637

aneeshakella-microsoft · 2023-08-23T08:46:41Z

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1363

Created changes in New-AzVirtualNetworkGateway and Update-VirtualNetworkGateway to support minimum scale units and maximum scale units. A min scale unit of 2 for instance would map to a minimum supported bandwidth of 2 GBPs while a maximum scale unit of 5 would map to a maximum supported bandwidth of 5 GBPs. The scale units in the backend will automatically modify depending on current customer parameters such as bandwidth.

Description

Checklist

[X ] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

Co-authored-by: Yeming Liu <[email protected]>

… of cmdlet output (#22495) * Exclude the api-version in typename when checking the breaking change of cmdlet output * Rename the function

* fix bug * changelog --------- Co-authored-by: Theodore Chang <[email protected]>

* Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions

Added the example of removing an API from a managed gateway. Users are not able to achieve it by following the first example and raising questions using support tickets.

* Move StackHCI to main * udpate changelog --------- Co-authored-by: YanaXu <[email protected]>

* wip * add update-azkeyvaultsetting and help docs * add example for settings * add change log * add live test * fix * fix

* Move ContainerInstance to main * Create containerGroups-containers.json * Create containerGroups.json --------- Co-authored-by: Beisi Zhou <[email protected]>

* Updated ChangeLog.md for Az.ContainerInstance * Update src/ContainerInstance/ChangeLog.md --------- Co-authored-by: Beisi Zhou <[email protected]>

* update artifact to 18 * fix change log error

* update SDK reference * resolve breaking change * update package reference * breaking change mitigation * breaking change suppression * re-record ssh test with latest compute API call --------- Co-authored-by: Theodore Chang <[email protected]>

* add compute.sdk project reference * add sdk folder * address comments * update commit version to inputs * rename Compute.Sdk folder to Compute.Management.Sdk * resolve xmls, change compute.sdk reference to compute.management.sdk * remove SDK reference. generate track 1 with latest DiskRP version * Update src/Compute/Compute.Management.Sdk/README.md Co-authored-by: Vincent Dai <[email protected]> * fix autorest cmd * update autorest gen * Update Compute.Management.Sdk.csproj * generated with latest swagger versions. 2023-04-02 diskRP 2023-07-01 CRP * update assembly version of sdk --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Vincent Dai <[email protected]>

* Refresh track 1 SDK * Added security domain properties into the output of New/Update/Get-AzKeyVaultManagedHsm (PSManagedHsm) * Refresh example

Co-authored-by: Theodore Chang <[email protected]>

* adding PremiumMV3 to Xenon list * updating changelog --------- Co-authored-by: Nalin Gaddis <[email protected]>

`New-AzVirtualSubnetConfig` does not exists but `New-AzVirtualNetworkSubnetConfig` does.

* Generate aks sdk with autorest.powershell * Suppress breaking changes caused by character case change

* Add live tests for MHSM Settings * enable all test cases

* disable error records persistence * add keys * upgrade common version * polish help message for 'DisableErrorRecordsPersistence' * Update src/Accounts/Authentication/Properties/Resources.resx Co-authored-by: Yeming Liu <[email protected]> * remove debug parameters for get/clear/update config * update environment variable name to AzPSDisableErrorRecordsPersistence --------- Co-authored-by: Yeming Liu <[email protected]>

…he track 1 SDK (#22579)

…egen2 item (#22563) * encryption context * Add changelog * update test dependency and help file * Add an example for encryption context

* Move StackHCI to main * update changelog --------- Co-authored-by: YanaXu <[email protected]>

…mentStack and Remove-Az*DeploymentStack cmdlets (#22519) * implemented stack object parameter sets for save and remove cmdlets * adjust tests and session records * adjusted changelog to reflect changes * adjust testing formatting * updating help docs * update cmdlets and help docs for renamed parameter * update sessions record tests

* Move DataMigration to main * update ChangeLog --------- Co-authored-by: YanaXu <[email protected]>

This reverts commit d8900c5.

This reverts commit bc4af78, reversing changes made to d8900c5.

…_powershell_changes

src/Network/Network/ChangeLog.md

YanaXu · 2023-08-24T06:43:18Z

Hi @aneeshakella-microsoft, please update the changelog. And update the title of this PR to a meaningful one, because it'll be used in the commit message.

YanaXu · 2023-08-25T06:17:23Z

/azp run

azure-pipelines · 2023-08-25T06:17:39Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-powershell-bot and others added 30 commits August 8, 2023 09:14

Bump up version for KeyVault (#22511)

d0f2e61

Merge remote-tracking branch 'upstream/main' into lnx/azurecore (#22349)

5b9e6d6

Co-authored-by: Yeming Liu <[email protected]>

Exclude the api-version in typename when checking the breaking change…

e991238

… of cmdlet output (#22495) * Exclude the api-version in typename when checking the breaking change of cmdlet output * Rename the function

fix Get-AzVmRunCommand bug (#22460)

5af6ca5

* fix bug * changelog --------- Co-authored-by: Theodore Chang <[email protected]>

Add permission for pr-label github actions (#22481)

0c544b3

* Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions * Add permission for pr-label github actions

Update Remove-AzApiManagementApiFromGateway.md (#22505)

15fa28f

Added the example of removing an API from a managed gateway. Users are not able to achieve it by following the first example and raising questions using support tickets.

Migrate StackHCI from generation to main (#22541)

4884e69

* Move StackHCI to main * udpate changelog --------- Co-authored-by: YanaXu <[email protected]>

[KeyVault] Support MHSM Settings (#22525)

c9a63e3

* wip * add update-azkeyvaultsetting and help docs * add example for settings * add change log * add live test * fix * fix

Migrate ContainerInstance from generation to main (#22537)

6d1d6e0

* Move ContainerInstance to main * Create containerGroups-containers.json * Create containerGroups.json --------- Co-authored-by: Beisi Zhou <[email protected]>

Updated ChangeLog.md for Az.ContainerInstance (#22550)

6f618d8

* Updated ChangeLog.md for Az.ContainerInstance * Update src/ContainerInstance/ChangeLog.md --------- Co-authored-by: Beisi Zhou <[email protected]>

[Synapse] Update artifact to 1.0.0-preview.18 (#22452)

f84cff8

* update artifact to 18 * fix change log error

workaround the assembly loading issue (#22551)

d2982c5

Bump up version for StackHCI (#22543)

d338b92

[KeyVault] Added security domain properties into PSManagedHsm (#22540)

cfd681c

* Refresh track 1 SDK * Added security domain properties into the output of New/Update/Get-AzKeyVaultManagedHsm (PSManagedHsm) * Refresh example

hibernate parameter for Stop-AzVmss (#22560)

d33f542

Co-authored-by: Theodore Chang <[email protected]>

Update PrLabeled.ps1 (#22553)

e9daac3

Adding XenonMV3 Support (#22530)

5393892

* adding PremiumMV3 to Xenon list * updating changelog --------- Co-authored-by: Nalin Gaddis <[email protected]>

Upgraded vulnerable DLLs after upgrading PowerShell SDK (#22566)

ac10d1b

Update New-AzVirtualNetworkSubnetConfig.md (#22561)

5e07fd4

`New-AzVirtualSubnetConfig` does not exists but `New-AzVirtualNetworkSubnetConfig` does.

Generate aks sdk with autorest.powershell (#22501)

0a1218b

* Generate aks sdk with autorest.powershell * Suppress breaking changes caused by character case change

[KeyVault] Add live tests for MHSM Settings (#22570)

9afbadd

* Add live tests for MHSM Settings * enable all test cases

Updated email notification to support multi-recipients (#22577)

e8b236f

Use autorest.powershell to generate AlertsManagement SDK to replace t…

ac379cd

…he track 1 SDK (#22579)

[Storage] Support encryption context property when creating a datalak…

83f0bfd

…egen2 item (#22563) * encryption context * Add changelog * update test dependency and help file * Add an example for encryption context

Migrate StackHCI from generation to main (#22588)

1cc9437

* Move StackHCI to main * update changelog --------- Co-authored-by: YanaXu <[email protected]>

Migrate DataMigration from generation to main (#22574)

74357e4

* Move DataMigration to main * update ChangeLog --------- Co-authored-by: YanaXu <[email protected]>

aneeshakella-microsoft requested review from bilaakpan-ms, Sandido, haagha and grizzlytheodore as code owners August 23, 2023 17:58

aneeshakella-microsoft added 3 commits August 23, 2023 11:00

Revert "formatting changes"

7a21a1d

This reverts commit d8900c5.

Revert " fixed merge issues"

942538e

This reverts commit bc4af78, reversing changes made to d8900c5.

Merge branch 'release-network-2023-05-01' into aneeshakella/ergwscale…

1c6b6c8

…_powershell_changes

aneeshakella-microsoft added the needs-review label Aug 23, 2023

aneeshakella-microsoft added 4 commits August 23, 2023 14:07

finished changes

5c6bc4a

formatting

729dfce

formatting

a6a37bc

formatting

3c220b3

YanaXu reviewed Aug 24, 2023

View reviewed changes

src/Network/Network/ChangeLog.md Outdated Show resolved Hide resolved

YanaXu added needs-revision and removed needs-review labels Aug 24, 2023

aneeshakella-microsoft changed the title ~~Aneeshakella/ergwscale powershell changes~~ Adding Autoscaling Capabilities to Virtual Network Gateway Aug 24, 2023

edited ChangeLog

0a84934

aneeshakella-microsoft added the needs-review label Aug 24, 2023

aneeshakella-microsoft added 2 commits August 24, 2023 00:22

added empty line

4e7ee11

added empty line between 6.1.1 and 6.1.0

0498f59

YanaXu added Waiting for CI and removed needs-revision needs-review labels Aug 24, 2023

aneeshakella-microsoft requested a review from YanaXu August 24, 2023 17:48

YanaXu approved these changes Aug 25, 2023

View reviewed changes

YanaXu merged commit af1ac14 into Azure:release-network-2023-05-01 Aug 25, 2023

VeryEarly mentioned this pull request Sep 28, 2023

[Eng]: CI check whether SDK was generated not functioning properly #22875

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Autoscaling Capabilities to Virtual Network Gateway #22637

Adding Autoscaling Capabilities to Virtual Network Gateway #22637

aneeshakella-microsoft commented Aug 23, 2023 •

edited

Loading

YanaXu commented Aug 24, 2023

YanaXu commented Aug 25, 2023

azure-pipelines bot commented Aug 25, 2023

Adding Autoscaling Capabilities to Virtual Network Gateway #22637

Adding Autoscaling Capabilities to Virtual Network Gateway #22637

Conversation

aneeshakella-microsoft commented Aug 23, 2023 • edited Loading

Description

Checklist

YanaXu commented Aug 24, 2023

YanaXu commented Aug 25, 2023

azure-pipelines bot commented Aug 25, 2023

aneeshakella-microsoft commented Aug 23, 2023 •

edited

Loading