Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding keyvault for autogeneration #762

Closed
wants to merge 3 commits into from
Closed

Onboarding keyvault for autogeneration #762

wants to merge 3 commits into from

Conversation

anthony-c-martin
Copy link
Member

> [email protected] generate-single C:\github\azure-resource-manager-schemas\generator
> ts-node cmd/generatesingle "keyvault/resource-manager"

[C:\Users\antmarti\AppData\Local\Temp\schm_azspc] executing: git fsck
[C:\Users\antmarti\AppData\Local\Temp\schm_azspc] executing: git reset -q .
[C:\Users\antmarti\AppData\Local\Temp\schm_azspc] executing: git checkout -q -- .
[C:\Users\antmarti\AppData\Local\Temp\schm_azspc] executing: git clean -q -fd
[C:\Users\antmarti\AppData\Local\Temp\schm_azspc] executing: git gc
[C:\Users\antmarti\AppData\Local\Temp\schm_azspc] executing: git fetch
[C:\Users\antmarti\AppData\Local\Temp\schm_azspc] executing: git checkout -q origin/master
Using whitelist config:
{
  "basePath": "keyvault/resource-manager",
  "namespace": "Microsoft.KeyVault"
}
[C:\github\azure-resource-manager-schemas\generator] executing: autorest-beta.cmd --azureresourceschema --azureresourceschema.multi-scope=true --output-folder=C:\Users\antmarti\AppData\Local\Temp\xf6i27t012l --tag=all-api-versions --api-version=2018-02-14-preview --title=none C:\Users\antmarti\AppData\Local\Temp\schm_azspc\specification\keyvault\resource-manager\readme.md
AutoRest code generation utility [version: 3.0.6118; node: v10.15.3, max-memory: 8192 gb]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      'C:\github\azure-resource-manager-schemas\generator\node_modules\@autorest\core\dist' (3.0.6126)
   Loading local AutoRest extension '@autorest/azureresourceschema' (C:\github\azure-resource-manager-schemas\generator\node_modules\@autorest\azureresourceschema)
[9.24 s] Generation Complete
================================================================================================================================
Filename: C:\Users\antmarti\AppData\Local\Temp\xf6i27t012l\2018-02-14-preview\Microsoft.KeyVault.json
Provider Namespace: Microsoft.KeyVault
API Version: 2018-02-14-preview
Resource Types (Resource Group Scope):
- vaults
- vaults/accessPolicies
- vaults/secrets
================================================================================================================================
[C:\github\azure-resource-manager-schemas\generator] executing: autorest-beta.cmd --azureresourceschema --azureresourceschema.multi-scope=true --output-folder=C:\Users\antmarti\AppData\Local\Temp\hnf5xsjgj25 --tag=all-api-versions --api-version=2015-06-01 --title=none C:\Users\antmarti\AppData\Local\Temp\schm_azspc\specification\keyvault\resource-manager\readme.md
AutoRest code generation utility [version: 3.0.6118; node: v10.15.3, max-memory: 8192 gb]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      'C:\github\azure-resource-manager-schemas\generator\node_modules\@autorest\core\dist' (3.0.6126)
   Loading local AutoRest extension '@autorest/azureresourceschema' (C:\github\azure-resource-manager-schemas\generator\node_modules\@autorest\azureresourceschema)
[6.16 s] Generation Complete
================================================================================================================================
Filename: C:\Users\antmarti\AppData\Local\Temp\hnf5xsjgj25\2015-06-01\Microsoft.KeyVault.json
Provider Namespace: Microsoft.KeyVault
API Version: 2015-06-01
Resource Types (Resource Group Scope):
- vaults
================================================================================================================================
[C:\github\azure-resource-manager-schemas\generator] executing: autorest-beta.cmd --azureresourceschema --azureresourceschema.multi-scope=true --output-folder=C:\Users\antmarti\AppData\Local\Temp\nz9z1wzw0eh --tag=all-api-versions --api-version=2016-10-01 --title=none C:\Users\antmarti\AppData\Local\Temp\schm_azspc\specification\keyvault\resource-manager\readme.md
AutoRest code generation utility [version: 3.0.6118; node: v10.15.3, max-memory: 8192 gb]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      'C:\github\azure-resource-manager-schemas\generator\node_modules\@autorest\core\dist' (3.0.6126)
   Loading local AutoRest extension '@autorest/azureresourceschema' (C:\github\azure-resource-manager-schemas\generator\node_modules\@autorest\azureresourceschema)
[7.59 s] Generation Complete
================================================================================================================================
Filename: C:\Users\antmarti\AppData\Local\Temp\nz9z1wzw0eh\2016-10-01\Microsoft.KeyVault.json
Provider Namespace: Microsoft.KeyVault
API Version: 2016-10-01
Resource Types (Resource Group Scope):
- vaults
- vaults/accessPolicies
================================================================================================================================
[C:\github\azure-resource-manager-schemas\generator] executing: autorest-beta.cmd --azureresourceschema --azureresourceschema.multi-scope=true --output-folder=C:\Users\antmarti\AppData\Local\Temp\40bsbskbtju --tag=all-api-versions --api-version=2018-02-14 --title=none C:\Users\antmarti\AppData\Local\Temp\schm_azspc\specification\keyvault\resource-manager\readme.md
AutoRest code generation utility [version: 3.0.6118; node: v10.15.3, max-memory: 8192 gb]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      'C:\github\azure-resource-manager-schemas\generator\node_modules\@autorest\core\dist' (3.0.6126)
   Loading local AutoRest extension '@autorest/azureresourceschema' (C:\github\azure-resource-manager-schemas\generator\node_modules\@autorest\azureresourceschema)
[8.07 s] Generation Complete
================================================================================================================================
Filename: C:\Users\antmarti\AppData\Local\Temp\40bsbskbtju\2018-02-14\Microsoft.KeyVault.json
Provider Namespace: Microsoft.KeyVault
API Version: 2018-02-14
Resource Types (Resource Group Scope):
- vaults
- vaults/accessPolicies
================================================================================================================================

@WillParry
Copy link

I had a look through the files changed. Looking at the Microsoft.KeyVault.json and the autogeneratedResources.json it looks like vaults and accesspolicies are included, but not secrets. Is that right? Have I missed or misunderstood? Thanks.

@anthony-c-martin
Copy link
Member Author

@WillParry that's unfortunately why this PR is sitting here unmerged. Secrets are a KV dataplane concept which have been also modeled in the ARM control plane to make deploying them via template possible.

However to avoid duplication when generating SDKs, they have not been included in the set of swagger definitions in the specs repo - which means we don't pick them up automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants