Skip to content

Commit

Permalink
[CDN] Add missing default values to fix swagger quality issues in s360 (
Browse files Browse the repository at this point in the history 
#23029)

* Add missing default value to fix s360

* Fix PrettierCheck issue

---------

Co-authored-by: Bo Zhang <[email protected]>
  • Loading branch information
@t-bzhan
t-bzhan and Bo Zhang authored Mar 30, 2023
1 parent f0e86b9 commit aceee26
Show file tree
Hide file tree
Showing 6 changed files with 226 additions and 72 deletions.
62 changes: 54 additions & 8 deletions specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-05-01-preview/afdx.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4736,7 +4736,43 @@
{
"$ref": "#/definitions/SecretParameters"
}
]
],
"properties": {
"secretSource": {
"description": "Resource reference to the Azure Key Vault certificate. Expected to be in format of /subscriptions/{​​​​​​​​​subscriptionId}​​​​​​​​​/resourceGroups/{​​​​​​​​​resourceGroupName}​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​/providers/Microsoft.KeyVault/vaults/{vaultName}​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​/secrets/{certificateName}​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​",
"type": "object",
"$ref": "./cdn.json#/definitions/ResourceReference",
"readOnly": true
},
"subject": {
"description": "Subject name in the certificate.",
"type": "string",
"readOnly": true
},
"expirationDate": {
"description": "Certificate expiration date.",
"type": "string",
"readOnly": true
},
"certificateAuthority": {
"description": "Certificate issuing authority.",
"type": "string",
"readOnly": true
},
"subjectAlternativeNames": {
"description": "The list of SANs.",
"type": "array",
"items": {
"type": "string",
"readOnly": true
}
},
"thumbprint": {
"description": "Certificate thumbprint.",
"type": "string",
"readOnly": true
}
}
},
"RuleSetListResult": {
"description": "Result of the request to list rule sets. It contains a list of rule set objects and a URL link to get the next set of results.",
Expand Down Expand Up @@ -4850,7 +4886,8 @@
"maximum": 65535,
"exclusiveMaximum": false,
"minimum": 1,
"exclusiveMinimum": false
"exclusiveMinimum": false,
"default": 80
},
"httpsPort": {
"description": "The value of the HTTPS port. Must be between 1 and 65535.",
Expand All @@ -4859,7 +4896,8 @@
"format": "int32",
"exclusiveMaximum": false,
"minimum": 1,
"exclusiveMinimum": false
"exclusiveMinimum": false,
"default": 443
},
"originHostHeader": {
"description": "The host header value sent to the origin with each request. If you leave this blank, the request hostname determines this value. Azure CDN origins, such as Web Apps, Blob Storage, and Cloud Services require this host header value to match the origin hostname by default. This overrides the host header defined at Endpoint",
Expand Down Expand Up @@ -5163,7 +5201,11 @@
"type": "array",
"items": {
"$ref": "#/definitions/AFDEndpointProtocols"
}
},
"default": [
"Http",
"Https"
]
},
"patternsToMatch": {
"description": "The route patterns of the rule.",
Expand All @@ -5189,7 +5231,8 @@
"x-ms-enum": {
"name": "ForwardingProtocol",
"modelAsString": true
}
},
"default": "MatchRequest"
},
"linkToDefaultDomain": {
"description": "whether this route will be linked to the default endpoint domain.",
Expand All @@ -5201,7 +5244,8 @@
"x-ms-enum": {
"name": "LinkToDefaultDomain",
"modelAsString": true
}
},
"default": "Disabled"
},
"httpsRedirect": {
"description": "Whether to automatically redirect HTTP traffic to HTTPS traffic. Note that this is a easy way to set up this rule and it will be the first rule that gets executed.",
Expand All @@ -5213,7 +5257,8 @@
"x-ms-enum": {
"name": "httpsRedirect",
"modelAsString": true
}
},
"default": "Disabled"
},
"enabledState": {
"description": "Whether to enable use of this rule. Permitted values are 'Enabled' or 'Disabled'",
Expand Down Expand Up @@ -5359,7 +5404,8 @@
"x-ms-enum": {
"name": "MatchProcessingBehavior",
"modelAsString": true
}
},
"default": "Continue"
}
}
},
Expand Down
69 changes: 46 additions & 23 deletions specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-05-01-preview/cdn.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2690,7 +2690,8 @@
"type": "object",
"additionalProperties": {
"type": "string"
}
},
"readOnly": true
},
"frontDoorId": {
"readOnly": true,
Expand Down Expand Up @@ -3075,15 +3076,18 @@
},
"isHttpAllowed": {
"description": "Indicates whether HTTP traffic is allowed on the endpoint. Default value is true. At least one protocol (HTTP or HTTPS) must be allowed.",
"type": "boolean"
"type": "boolean",
"default": true
},
"isHttpsAllowed": {
"description": "Indicates whether HTTPS traffic is allowed on the endpoint. Default value is true. At least one protocol (HTTP or HTTPS) must be allowed.",
"type": "boolean"
"type": "boolean",
"default": true
},
"queryStringCachingBehavior": {
"description": "Defines how CDN caches requests that include query strings. You can ignore any query strings when caching, bypass caching to prevent requests that contain query strings from being cached, or cache every request with a unique URL.",
"$ref": "#/definitions/QueryStringCachingBehavior"
"$ref": "#/definitions/QueryStringCachingBehavior",
"default": "NotSet"
},
"optimizationType": {
"description": "Specifies what scenario the customer wants this CDN endpoint to optimize for, e.g. Download, Media services. With this information, CDN can apply scenario driven optimization.",
Expand Down Expand Up @@ -3603,7 +3607,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "Match values to match against. The operator will apply to each value in here with OR semantics. If any of them match the variable with the given operator this match condition is considered a match.",
Expand Down Expand Up @@ -3647,7 +3652,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"transforms": {
"description": "List of transforms",
Expand Down Expand Up @@ -3709,7 +3715,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -3766,7 +3773,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -3819,7 +3827,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -3876,7 +3885,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -3929,7 +3939,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -3969,7 +3980,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"transforms": {
"description": "List of transforms",
Expand Down Expand Up @@ -4027,7 +4039,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4080,7 +4093,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4133,7 +4147,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4177,7 +4192,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4234,7 +4250,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4278,7 +4295,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4328,7 +4346,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4382,7 +4401,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4436,7 +4456,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4490,7 +4511,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down Expand Up @@ -4535,7 +4557,8 @@
},
"negateCondition": {
"description": "Describes if this is negate condition or not",
"type": "boolean"
"type": "boolean",
"default": false
},
"matchValues": {
"description": "The match value for the condition of the delivery rule",
Expand Down
Loading

0 comments on commit aceee26

Please sign in to comment.