-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger Correction #11329
Swagger Correction #11329
Conversation
Corrected Swagger based on report from https://aka.ms/LiveValidation
Hi, @amoghnatu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
Fixed model validation error
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Corrected description
Azure Pipelines successfully started running 1 pipeline(s). |
...cation/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/operations.json
Show resolved
Hide resolved
...e-manager/Microsoft.Synapse/preview/2019-06-01-preview/examples/CreateOrUpdateWorkspace.json
Show resolved
Hide resolved
...ification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json
Show resolved
Hide resolved
Fixed issues in pipeline
Added format as well
Azure Pipelines successfully started running 1 pipeline(s). |
Removed failing description to check
Azure Pipelines successfully started running 1 pipeline(s). |
Removed failing description to check
Azure Pipelines successfully started running 1 pipeline(s). |
fixing UnhandledPromiseRejectionWarning
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
...e/preview/2019-06-01-preview/nppBackup/privateEndpointConnections.json.2020-10-28_153436.bak
Outdated
Show resolved
Hide resolved
Pull request contains merge conflicts. |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @amoghnatu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Azure Pipelines successfully started running 1 pipeline(s). |
Idempotence | ||
privatelinkhub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This can be renames as privateLinkHub
to avoid spell check errors.
* Swagger Correction - First slice Corrected Swagger based on report from https://aka.ms/LiveValidation * Fixed model validation error Fixed model validation error * Corrected description Corrected description * Fixed issues in pipeline Fixed issues in pipeline * Added format as well Added format as well * Removed failing description to check Removed failing description to check * Removed failing description to check Removed failing description to check * fixing UnhandledPromiseRejectionWarning fixing UnhandledPromiseRejectionWarning * UnhandledPromiseRejectionWarning UnhandledPromiseRejectionWarning * Removed new line charaters that were being flagged as errors. Removed new line charaters that were being flagged as errors. * Fixing attempt for UnhandledPromiseRejectionWarning Fixing attempt for UnhandledPromiseRejectionWarning * Removed hopefully all descriptions * UnhandledPromiseRejectionWarning * Removed duplicate definition * Removed duplicate definition * Removed duplicate definition * Added custom word * Corrected example. * Fixed some issues * Removed nppBackup file. Co-authored-by: Amogh Natu <[email protected]>
Corrected Swagger based on report from https://aka.ms/LiveValidation
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.