Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support discrimitor and readonly at same time #11480

Merged
merged 2 commits into from
Nov 5, 2020
Merged

support discrimitor and readonly at same time #11480

merged 2 commits into from
Nov 5, 2020

Conversation

chenjianfei2017
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 2, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️❌BreakingChange: 7 Errors, 0 Warnings [Detail] [Expand]
Rule Message
❌ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
❌ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
❌ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
❌ 1034 - AddedRequiredProperty The new version has new required property 'resourceType' that was not found in the old version.
New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1687:7
❌ 1034 - AddedRequiredProperty The new version has new required property 'targetResourceName' that was not found in the old version.
New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1687:7
❌ 1034 - AddedRequiredProperty The new version has new required property 'resourceType, targetResourceName' that was not found in the old version.
New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1209:9
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
️️✔️ModelValidation [Detail] 
 Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail] 
 Validation passes for SemanticValidation.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 2, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 9ccb501 with merge commit edfc93e. SDK Automation 13.0.17.20200918.2 
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/2689: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 14:17:05 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07C5:7208:2A7BD76:6C51035:5FA40961","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4786","x-ratelimit-reset":"1604586990","x-ratelimit-used":"214","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-resourcemover@11480","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/2690: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 14:17:06 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07C7:7E49:2E37DD8:68689B2:5FA40961","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4785","x-ratelimit-reset":"1604586990","x-ratelimit-used":"215","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-resourcemover@11480","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
[azure-mgmt-resourcemover][breaking_change_report_pypi] WARNING:__main__:Version 1.0.1b1 seems to be too old to build a report (probably not Autorest based)
[azure-mgmt-resourcemover][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-resourcemover [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-resourcemover
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-resourcemover
[build_conf] INFO:packaging_tools:Template done azure-mgmt-resourcemover
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
[build_package]   normalized_version,
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
[build_package]   normalized_version,
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_report_pypi] WARNING:__main__:Version 1.0.1b1 seems to be too old to build a report (probably not Autorest based)
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 2, 2020 •
edited
Loading

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9ccb501 with merge commit edfc93e. Schema Automation 13.0.17.20200918.2 
    [resourcemover][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[resourcemover][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[resourcemover][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️resourcemover [View full logs]  [Release Schema Changes] 
      [after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5806 passing (1m)
AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 2, 2020 •
    edited
    Loading

    azure-sdk-for-python-track2 - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 9ccb501 with merge commit edfc93e. SDK Automation 13.0.17.20200918.2 
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-moveStatus' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-errors' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SubnetReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'LoadBalancerBackendAddressPoolReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'LoadBalancerNatRuleReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SqlServerResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceGroupResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-moveStatus' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-errors' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceFilterProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[track2_azure-mgmt-resourcemover][breaking_change_report_pypi] WARNING:__main__:Version 1.0.1b1 seems to be too old to build a report (probably not Autorest based)
[track2_azure-mgmt-resourcemover][ChangeLog] WARNING: Failed to generate ChangeLog.
    • ⚠️azure-mgmt-resourcemover [View full logs]  [Release SDK Changes] 
      [build_conf_init]   Cache entry deserialization failed, entry ignored
[build_conf_init]   Cache entry deserialization failed, entry ignored
[build_conf] INFO:packaging_tools:Building template azure-mgmt-resourcemover
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-resourcemover
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
[build_package]   normalized_version,
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
[build_package]   normalized_version,
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_report_pypi] WARNING:__main__:Version 1.0.1b1 seems to be too old to build a report (probably not Autorest based)
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 2, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 2, 2020 •
    edited
    Loading

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 2, 2020 •
    edited
    Loading

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 2, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 9ccb501 with merge commit edfc93e. SDK Automation 13.0.17.20200918.2 
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 2, 2020 •
    edited
    Loading

    azure-sdk-for-net - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 2, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 9ccb501 with merge commit edfc93e. SDK Automation 13.0.17.20200918.2 
      Failed to find any diff after autorest so no changed packages was found.

    This was referenced Nov 2, 2020
    Closed
    Closed
    Closed
    @PhoenixHe-NV PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 2, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @PhoenixHe-NV
    Copy link
    Contributor

    @chenjianfei2017 Do you want to merge this one?

    @chenjianfei2017
    Copy link
    Contributor Author

    chenjianfei2017 commented Nov 5, 2020 via email

    @PhoenixHe-NV PhoenixHe-NV merged commit edfc93e into master Nov 5, 2020
    @ajaygit158 ajaygit158 mentioned this pull request Nov 23, 2020
    Merged
    7 tasks
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    @chenjianfei2017
    support discrimitor and readonly at same time (Azure#11480)
    018199a 
    * support discrimitor and readonly at same time

* add trenton file and overrides
    @chenjianfei2017 chenjianfei2017 deleted the resoucemover branch February 4, 2021 06:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @PhoenixHe-NV PhoenixHe-NV PhoenixHe-NV approved these changes

    @innosam innosam Awaiting requested review from innosam

    Assignees

    @PhoenixHe-NV PhoenixHe-NV

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @chenjianfei2017 @PhoenixHe-NV